Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checked radio does not display properly #5672

Open
swiing opened this issue Feb 8, 2025 · 3 comments · May be fixed by #5673
Open

Checked radio does not display properly #5672

swiing opened this issue Feb 8, 2025 · 3 comments · May be fixed by #5673
Assignees
Labels
bug Something isn't working react

Comments

@swiing
Copy link

swiing commented Feb 8, 2025

Description

A radio button is expected to be visually differentiated when checked.
It is not the case with @primer/react v37.11.2

Steps to reproduce

import { Radio, RadioGroup } from "@primer/react";

export default function App() {
  return (<RadioGroup name="type">
    <Radio value="foo" checked />
    <Radio value="bar" />
  </RadioGroup>)
}

CodeSanbox

Version

v37.11.2

Browser

Edge

@swiing swiing added the bug Something isn't working label Feb 8, 2025
@sushanthi1813
Copy link

The root render was updated so that the App is now wrapped in and . This change ensures that the global theming and base CSS provided by @primer/react are applied across your application. The application relies on these components to correctly style UI elements (including components like the Radio button). Without these wrappers, the app might not show the intended visual differentiation or styling.

@Bkabig
Copy link

Bkabig commented Feb 10, 2025

Description

@swiing
Copy link
Author

swiing commented Feb 10, 2025

Thanks @sushanthi1813
If you are referring to Theme provider, please note that checked radio does not visually render differentiated, even when encapsulated inside ThemeProvider and BaseStyle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working react
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants