Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FBref] Add support for scraping detailed player information #779

Open
baniasbaabe opened this issue Jan 2, 2025 · 2 comments
Open

[FBref] Add support for scraping detailed player information #779

baniasbaabe opened this issue Jan 2, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@baniasbaabe
Copy link

Retrieving more information about a specific player like club history would be nice!

@baniasbaabe baniasbaabe added the enhancement New feature or request label Jan 2, 2025
@probberechts probberechts changed the title More detailed player information (FBRef) [FBref] Add support for scraping detailed player information Jan 21, 2025
@babu-akhil
Copy link
Contributor

I'd be willing to work on this.

@probberechts On the implementation for this, I am thinking to implement a function like fbref.read_player_club_history(player_id) with using player_id like '507c7bdf' (https://fbref.com/en/players/507c7bdf/ links to Bruno Fernandes). Would this be a good approach?

Or do you think it is better to have more abstractions like fbref_player classes which can then have multiple functions for scraping for the various information on the player page , none of which are supported right now.

@probberechts
Copy link
Owner

The issue here is that the FBref class should be initialized with a league and season. All functions in that class than only return data for the given league and season. This is not desirable when you scrape a player's club history. Therefore, I think a better solution would be to add a FBrefPlayer class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants