Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the t&c portion of the signup page isn't translated correctly #3274

Open
prudvinani opened this issue Nov 13, 2024 · 5 comments · May be fixed by #3275
Open

the t&c portion of the signup page isn't translated correctly #3274

prudvinani opened this issue Nov 13, 2024 · 5 comments · May be fixed by #3275

Comments

@prudvinani
Copy link

p5.js version

No response

What is your operating system?

None

Web browser and version

No response

Actual Behavior

it isn't being translated

Expected Behavior

it should be translated

WhatsApp Image 2024-11-13 at 6 48 48 AM

Steps to reproduce

Steps:

Snippet:

// Paste your code here :)
@prudvinani prudvinani added the Bug label Nov 13, 2024
Copy link

welcome bot commented Nov 13, 2024

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@ujjwaldubey1
Copy link

ujjwaldubey1 commented Nov 14, 2024

@raclim I can help in this

@Deepeshjoshi123
Copy link

hey can I work on this issue as it is not closed?

Harshit-7373 added a commit to Harshit-7373/p5.js-web-editor that referenced this issue Feb 11, 2025
Solved the issue processing#3274  the t&c portion of the signup page isn't translated correctly processing#3274

1. I have added and updated the "Warning" line in the translation.json files for all respective languages.
@Harshit-7373 Harshit-7373 mentioned this issue Feb 11, 2025
4 tasks
@Harshit-7373
Copy link
Contributor

@prudvinani I have fixed these issues in my pull request. These will be updated soon. Thank you so much for highlighting the issues!

@raclim Please Review my PR & merge the PR to close the Issue.

@Harshit-7373
Copy link
Contributor

Image

In the uploaded image, you can see that the entire line "By signing up, you agree to the p5.js Editor's" is now correctly displayed according to the selected language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment