Skip to content

Commit cb40694

Browse files
committed
fix(ci): separate step for manifest bump
1 parent 4031b5a commit cb40694

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

.github/workflows/nightly.yml

+11-8
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,11 @@ on:
1313
- master
1414

1515
jobs:
16-
create-nightly-release:
17-
name: Create Nightly release
16+
bump_manifest:
17+
name: Bump manifest version
1818
runs-on: ubuntu-latest
19+
outputs:
20+
release_tag: {{ steps.get_tag.outputs.release_tag }}
1921

2022
steps:
2123
- name: Checkout source code
@@ -48,13 +50,14 @@ jobs:
4850
author_email: 41898282+github-actions[bot]@users.noreply.github.com
4951
message: "chore: bump manifest version to nightly ${{ steps.get_tag.outputs.release_tag }}"
5052

51-
52-
# super hacky
53+
create-nightly-release:
54+
name: Create Nightly release
55+
runs-on: ubuntu-latest
56+
steps:
5357
- name: Checkout source code
5458
uses: actions/checkout@v4
5559
with:
5660
fetch-depth: 0
57-
ref: ${{ steps.commit_manifest.outputs.commit_sha }}
5861

5962
- name: Install pnpm
6063
uses: pnpm/[email protected]
@@ -69,7 +72,7 @@ jobs:
6972
run: pnpm i --frozen-lockfile
7073

7174
- name: Run build
72-
run: REACT_APP_VERSION=${{ steps.get_tag.outputs.release_tag }} pnpm build
75+
run: REACT_APP_VERSION=${{ needs.bump_manifest.outputs.release_tag }} pnpm build
7376

7477
#- name: Create Sentry Release (NPWD)
7578
# run: |
@@ -98,9 +101,9 @@ jobs:
98101
id: auto_release
99102
with:
100103
environment: "dev"
101-
title: NPWD Nightly ${{ steps.get_tag.outputs.release_tag }}
104+
title: NPWD Nightly ${{ needs.bump_manifest.outputs.release_tag }}
102105
prerelease: true
103-
automatic_release_tag: ${{ steps.get_tag.outputs.release_tag }}
106+
automatic_release_tag: ${{ needs.bump_manifest.outputs.release_tag }}
104107
files: npwd.zip
105108
env:
106109
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

0 commit comments

Comments
 (0)