Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not handling tombstone room #406

Open
alanpoon opened this issue Feb 26, 2025 · 4 comments
Open

Not handling tombstone room #406

alanpoon opened this issue Feb 26, 2025 · 4 comments
Assignees

Comments

@alanpoon
Copy link
Contributor

  1. When changing a room to tombstone room, there is failedToParseState in the events in the timeline.
  2. Missing notification: "This room has been replaced and is no longer active."
  3. Missing Link to link to new room: "The conversation continues here"
  4. Should not allow anymore messaging.

For instruction on how to tombstone a room:
https://ems-docs.element.io/books/element-cloud-documentation/page/frequently-asked-questions#bkmrk-manual-tombstone

Image

@alanpoon alanpoon changed the title Not handling tombstone room and events Not handling tombstone room and state event Feb 26, 2025
@alanpoon
Copy link
Contributor Author

matrix-org/matrix-rust-sdk#4211 (comment)

It seems like there is state event for tombstone room, but there is parse error.

@alanpoon alanpoon self-assigned this Feb 26, 2025
@alanpoon
Copy link
Contributor Author

Ignore ParseError as I needed to add a body field.

@alanpoon alanpoon changed the title Not handling tombstone room and state event Not handling tombstone room Feb 26, 2025
@alanpoon
Copy link
Contributor Author

Image
After checking with Element X, element X also has not handled tombstone room. It is because room.is_tombstone() returns false.

Ways to determine if a room is tombstone:

  1. Client.sync_once() -> not advisable
  2. Search through state messages for event_type: "m.room.tombstone"
  3. Look for other ways like SubscribeToOwnUserReadReceiptsChanged.

@kevinaboos
Copy link
Member

did you actually get tombstoned rooms to be marked as tombstoned according to the SDK? I never got them to work; see #178.

Even this Matrix SDK PR did not help: matrix-org/matrix-rust-sdk#4211

I'm hoping that maybe an upgrade to the latest version of the SDK might help.... but I'm not confident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants