Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demos should be refactored to be consistent with modern react standards and styles #1006

Open
Cpt-Falcon opened this issue May 30, 2023 · 2 comments

Comments

@Cpt-Falcon
Copy link

Demos are still using very old class style components

@kilotone
Copy link

kilotone commented Dec 3, 2023

Might benefit from using state/effect and custom hooks as well. I extended custom components using react fc and some material and joyui components, was fairly straightforward, but adding custom hooks would really shine for the equivalent of useModel, useSerialize useFlowState, and useDiagramTransition.

@kilotone
Copy link

I was able to mostly migrate to functional components and hooks, the only problems seemed to be the class components use of force update calls, and some dangerously set innerhtml.
I can submit a pr if there's interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants