Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print !ie correctly instead of !important #115

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

bartveneman
Copy link
Member

closes #114

Copy link

codecov bot commented Feb 4, 2025

Bundle Report

Changes will increase total bundle size by 130 bytes (1.17%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
formatCss-formatCss-esm 6.63kB 72 bytes (1.1%) ⬆️
formatCss-formatCss-esm-formatCss-umd 4.63kB 58 bytes (1.27%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: formatCss-formatCss-esm-formatCss-umd

Assets Changed:

Asset Name Size Change Total Size Change (%)
format-*.umd.cjs 58 bytes 4.63kB 1.27%

Files in format-*.umd.cjs:

  • ./index.js → Total Size: 16.08kB
view changes for bundle: formatCss-formatCss-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
format-*.js 72 bytes 6.63kB 1.1%

Files in format-*.js:

  • ./index.js → Total Size: 16.08kB

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9ca5cee) to head (4922bec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #115   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          576       578    +2     
=========================================
+ Hits           576       578    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 4, 2025

CodSpeed Performance Report

Merging #115 will degrade performances by 31.14%

Comparing print-string-important (4922bec) with main (9ca5cee)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 2 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
minify syntax.fm.css (61.6kB) 232.4 ms 167.2 ms +38.98%
nerdy.dev.css (70.6kB) 192 ms 278.8 ms -31.14%

@bartveneman bartveneman merged commit d285a2e into main Feb 4, 2025
6 checks passed
@bartveneman bartveneman deleted the print-string-important branch February 4, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

color: red !ie is printed as color: red !important
1 participant