Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move print functions inside main fn to avoid weird globals #73

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Move print functions inside main fn to avoid weird globals #73

merged 1 commit into from
Jul 26, 2024

Conversation

bartveneman
Copy link
Member

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024

Bundle Report

Changes will decrease total bundle size by 33 bytes ⬇️

Bundle name Size Change
formatCss-formatCss-esm 4.76kB 81 bytes ⬆️
formatCss-formatCss-esm-formatCss-umd 3.53kB 114 bytes ⬇️

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 26, 2024

CodSpeed Performance Report

Merging #73 will improve performances by 34.29%

Comparing no-globals (4f1748d) with main (ed08605)

Summary

⚡ 1 improvements
✅ 3 untouched benchmarks

Benchmarks breakdown

Benchmark main no-globals Change
⚡ nerdy.dev.css (70.6kB) 263.2 ms 196 ms +34.29%

@bartveneman bartveneman merged commit 00fac14 into main Jul 26, 2024
5 checks passed
@bartveneman bartveneman deleted the no-globals branch July 26, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bartveneman