Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded )s(?) confuse the highlighter, trailing ) highlighted red #13

Open
nabijaczleweli opened this issue Dec 18, 2022 · 2 comments
Open

Comments

@nabijaczleweli
Copy link

Consider the following snippet (part of dash):

AC_ARG_ENABLE(test-workaround, AS_HELP_STRING(--enable-test-workaround, \
	[Guard against faccessat(2) that tells root all files are executable]),,
	[enable_test_workaround=auto])

This is correct and uses all-upstream-autoconf macros. However, it highlights as such:

Cf. also:

AC_LINK_IFELSE([AC_LANG_PROGRAM([void t() {}
                                 void a() __attribute__((__alias__("t")));],
                                [a();])],
               [dash_cv_have_attribute_alias=yes])

@ptomato
Copy link
Owner

ptomato commented Dec 29, 2022

I'm not sure if ignoring the parentheses inside the bracketed argument to AS_HELP_STRING would be technically correct or not. What if you preceded it with m4_define([faccessat], [...])? But regardless, the current result, with an unbalanced bracket in the enclosing macro, seems incorrect. I'd welcome a pull request to fix this.

@dnicolson
Copy link
Contributor

The following code might have the same problem:

AC_DEFUN([FUNC],[
  AC_SUBST([XXX],[YYY])
])

PixelSnap 2023-11-27 at 20 16 07@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants