Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form view switcher #1036

Open
gabestein opened this issue Mar 6, 2025 · 4 comments
Open

Form view switcher #1036

gabestein opened this issue Mar 6, 2025 · 4 comments

Comments

@gabestein
Copy link
Member

gabestein commented Mar 6, 2025

Depends on #1035 and #1037

Motivation

So editors and admins can switch between various form views and forms

Requirements

  • On both the pub update and view pages:
    • If user has access to more than one form, adds a dropdown to the top that shows all the forms and allows them to switch between views
    • When new view is selected, page reloads showing that form's view, per the logic of Use Forms to construct Pub view #1035
    • Form does not save when switch is made, but user should be warned before page reloads of unsaved changes using current unsaved changes dialog

Acceptance Criteria

Mockups (if available)

Image

@allisonking
Copy link
Contributor

just to be clear, this doesn't save anything to the backend, right? i.e. switching this view has no impact on which form shows up when you start editing the pub?

@kalilsn
Copy link
Member

kalilsn commented Mar 10, 2025

Should this show on the pub details page and the pub update page? Or just the details page? And if contributors can have access to multiple forms, then I think we should show the switcher when there are multiple forms available that the user can access, regardless of their role.

@3mcd 3mcd added the 1-day label Mar 10, 2025
@gabestein
Copy link
Member Author

just to be clear, this doesn't save anything to the backend, right? i.e. switching this view has no impact on which form shows up when you start editing the pub?

Yes, good catch! Updated.

Should this show on the pub details page and the pub update page? Or just the details page? And if contributors can have access to multiple forms, then I think we should show the switcher when there are multiple forms available that the user can access, regardless of their role.

Both, and agree! Updated. Thank you!!

@gabestein gabestein moved this from Refining to In Progress in PubPub Legacy & Platform Combined Workstreams Mar 10, 2025
@gabestein gabestein moved this from In Progress to Ready in PubPub Legacy & Platform Combined Workstreams Mar 10, 2025
@gabestein gabestein moved this from Ready to In Progress in PubPub Legacy & Platform Combined Workstreams Mar 10, 2025
@gabestein
Copy link
Member Author

gabestein commented Mar 11, 2025

Question: when multiple forms are available, how do we let the admin specify which one comes first?

Kalil: save most recently used form?

Default for now: default form

Eventually, first time: user can set/change default form for given type

Eventually, subsequent times: load last viewed form by user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants