(GH-242) Ensure catalog passing when raw_catalog_access flag specified

This commit updates the BaseContext class initialization method
to take a second argument, catalog (default to nil), which
ensures that the @catalog instance variable is populated with
the value passed.

It also updates the context method in resource_api to pass the
catalog to that initializer if specified, or pass nil if not.

This does not add unit or acceptance tests for the behavior.

Author: michaeltlombardi

lib/puppet/resource_api.rb

@@ -430,7 +430,7 @@ def strict_check_title_parameter(current_state)
       end
 
       def context
-        @context ||= PuppetContext.new(TypeDefinition.new(definition), type_definition.feature?('raw_catalog_access') ? @catalog : nil)
+        @context ||= PuppetContext.new(type_definition, type_definition.feature?('raw_catalog_access') ? @catalog : nil)
       end
 
       def self.title_patterns

lib/puppet/resource_api/base_context.rb

@@ -11,7 +11,7 @@ class Puppet::ResourceApi::BaseContext
   attr_reader :type
   attr_reader :catalog
 
-  def initialize(definition)
+  def initialize(definition, catalog = nil)
     if definition.is_a?(Hash)
       # this is only for backwards compatibility
       @type = Puppet::ResourceApi::TypeDefinition.new(definition)
@@ -20,6 +20,7 @@ def initialize(definition)
     else
       raise ArgumentError, 'BaseContext requires definition to be a child of Puppet::ResourceApi::BaseTypeDefinition, not <%{actual_type}>' % { actual_type: definition.class }
     end
+    @catalog = catalog
   end
 
   def device