Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No line spacing between prompts #356

Open
parnavh opened this issue Nov 17, 2024 · 5 comments · May be fixed by #357
Open

No line spacing between prompts #356

parnavh opened this issue Nov 17, 2024 · 5 comments · May be fixed by #357
Labels
🐛 bug something that doesn't works as expected

Comments

@parnavh
Copy link

parnavh commented Nov 17, 2024

Env

Pure

4.11.0

Fish

3.7.1

OS/distribution

Distributor ID: NixOS
Description: NixOS 24.11 (Vicuna)
Release: 24.11
Codename: vicuna

Installed prompt by installing the fishPlugins.pure package as a systemPackage

image

I don't know if this is intended or the nixos package messes it up or there is a variable to configure this (I couldn't find one) but I can't get a line space between the prompts

Could someone please guide me
@Sounak008
Copy link

Same issue

@edouard-lopez
Copy link
Member

This seems related to #293 . Fix in #326 doesn't seem to work.

Try manually calling

type _pure_prompt_new_line

@edouard-lopez edouard-lopez added the 🐛 bug something that doesn't works as expected label Dec 17, 2024
edouard-lopez added a commit that referenced this issue Dec 19, 2024
@edouard-lopez
fix: source _pure_prompt_new_line event handler instead of relying on…
215acb1 
… autoloading

From the doc: https://fishshell.com/docs/current/language.html#event
> Please note that event handlers only become active when a function is loaded,
> which means you need to otherwise source or execute a function instead of
> relying on autoloading.

fix #356
@edouard-lopez edouard-lopez linked a pull request Dec 19, 2024 that will close this issue
Open
15 tasks
@edouard-lopez
Copy link
Member

@parnavh Could you try #357 ?

@parnavh
Copy link
Author

parnavh commented Dec 23, 2024

This seems related to #293 . Fix in #326 doesn't seem to work.

Try manually calling

type _pure_prompt_new_line

output:

_pure_prompt_new_line is a function with definition
# Defined in ~/.nix-profile/share/fish/vendor_functions.d/_pure_prompt_new_line.fish @ line 1
function _pure_prompt_new_line --description 'Do not add a line break to a brand new session' --on-event fish_prompt

    set --local new_line ''
    if not _pure_is_single_line_prompt; and test "$_pure_fresh_session" = false
        set new_line "\n"
    end

    echo -e -n (_pure_prompt_beginning)"$new_line"
end

@parnavh
Copy link
Author

parnavh commented Dec 23, 2024

@parnavh Could you try #357 ?

WIll do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug something that doesn't works as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: source _pure_prompt_new_line event handler instead of relying on autoloading pure-fish/pure
3 participants
@edouard-lopez @parnavh @Sounak008