Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH]deprecate then function #1259

Merged
merged 2 commits into from
May 13, 2023
Merged

[ENH]deprecate then function #1259

merged 2 commits into from
May 13, 2023

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented May 3, 2023 •
edited
Loading

PR Description

Please describe the changes proposed in the pull request:

  • deprecate then function

This PR resolves #1045.

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@samukweku samukweku self-assigned this May 3, 2023
@ericmjl
Copy link
Member

ericmjl commented May 3, 2023 •
edited
Loading

🚀 Deployed on https://deploy-preview-1259--pyjanitor.netlify.app

@codecov
Copy link

codecov bot commented May 3, 2023 •
edited
Loading

Codecov Report

Merging #1259 (0b84ed9) into dev (6dbd74e) will increase coverage by 10.21%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              dev    #1259       +/-   ##
===========================================
+ Coverage   87.25%   97.46%   +10.21%     
===========================================
  Files          78       78               
  Lines        3672     3675        +3     
===========================================
+ Hits         3204     3582      +378     
+ Misses        468       93      -375

ericmjl
ericmjl approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is an easy approve. Thank you, @samukweku! I am going to merge asap.

@ericmjl ericmjl merged commit cc5aa74 into dev May 13, 2023
@ericmjl ericmjl deleted the samukweku/then_deprecate branch May 13, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmjl ericmjl ericmjl approved these changes

@Zeroto521 Zeroto521 Awaiting requested review from Zeroto521

@thatlittleboy thatlittleboy Awaiting requested review from thatlittleboy

Assignees

@samukweku samukweku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate functions ?
2 participants
@samukweku @ericmjl