Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.clean_names() should replace @ with _ #1257

Open
GegznaV opened this issue Apr 14, 2023 · 5 comments
Open

.clean_names() should replace @ with _ #1257

GegznaV opened this issue Apr 14, 2023 · 5 comments
Labels
hacktoberfest For Hacktober issues :)

Comments

@GegznaV
Copy link

GegznaV commented Apr 14, 2023

Brief Description

Consider the following example in which @ symbol is not converted into _ in Column@Three:

import pandas as pd
import janitor

df = pd.DataFrame({
    'Column One': [1, 2, 3],
    'Column-Two': [4, 5, 6],
    'Column@Three': [7, 8, 9],
})

df_cleaned = df.clean_names()
print(df_cleaned)
#>    column_one  column_two  column@three
#> 0           1           4             7
#> 1           2           5             8
#> 2           3           6             9

.clean_names() should replace @ with _ as it does in R:

janitor::make_clean_names("Column@Tree")
#> [1] "column_tree"

System Information

  • Operating system: Windows
  • OS details (optional): Windows 10
  • Python version (required): 3.9 and 3.11

Minimally Reproducible Code

See above

Error Messages

None.

@samukweku
Copy link
Collaborator

@GegznaV thanks for raising this issue. Would you be open to raising a PR for this?

@deltahedge1
Copy link

is this repo part of hacktoberfest? would like to try and tackle this one as part of that event

@ericmjl
Copy link
Member

ericmjl commented Oct 8, 2023

@deltahedge1 we can make it part of Hacktoberfest! I'll tag this as part of hacktoberfest, I think that should make the repo eligible, right?

@ericmjl ericmjl added the hacktoberfest For Hacktober issues :) label Oct 8, 2023
@deltahedge1
Copy link

perfect! let me take a look at this one. Thanks for adding the tag. full disclosure I am unsure if adding the tag makes it part of the event but one way to find out

@ericmjl
Copy link
Member

ericmjl commented Oct 8, 2023

@deltahedge1 let's see if that works! If you do need me to vouch for your PR, then you can send the Hacktoberfest organizers my way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest For Hacktober issues :)
Projects
None yet
Development

No branches or pull requests

4 participants