type hinting

[untzag]

Is there a type stub library for pymodbus? Is there any desire in the community for this package to be type hinted? From what I have seen (only surface level) this would be relatively easy to type hint.

[dhoomakethu]

Yes, type hinting is a good to have but we inherit a lot of legacy code which we are in the process of cleaning up. Type hinting is being used in some new code that is going in. Would love if there are pull requests to accommodate this.

[swamper123]

Typehinting would be very cool. Like dhoomeakethu says, lot's of stuff is being touched recently for the bigger 3.0 Version. Guess if 3.0 fits, it could be one of the next milestones (and perhaps mypy could be (re?)activated then).

[janiversen]

type hinting at interface level is absolutely cool and something I would like to see. Internally I am less sure, because we sometimes pass some items that demands a pretty long type hint (which are typically only used once).

Look forward to see some pull requests.

[untzag]

I'm hearing "yes we want this, but should wait until after 3.0". I'm patient and happy to wait.

[janiversen]

that is not what I wrote, there are no need to wait until 3.0 is released. The interfaces will not change a lot, so feel free to start and I will review the pull requests.

[untzag]

Sounds good

[janiversen]

Any progress on the theme ?

[untzag]

Still on my TODO list!

[janiversen]

We have decided that all API´s should have type hints (accurate ones and not just e.g. dict),

Internal methods depend on whether or not they are used in multiple places.

We expect to use mypy soon to enforce this.

[alexrudd2]

@untzag Much progress has been made on this front recently, if you'd like to take another look.