Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation doesn't build a pdf #294

Open
martinfleis opened this issue Aug 10, 2021 · 8 comments
Open

Documentation doesn't build a pdf #294

martinfleis opened this issue Aug 10, 2021 · 8 comments
Labels

Comments

@martinfleis
Copy link
Member

RTD refuses to build a PDF because of the huge amount of numpy deprecation warnings in there (geopandas/geopandas#2013). I have disabled the option for now but we should re-enable it once it gets fixed in geopandas 0.10.0.

@jGaboardi
Copy link
Member

@martinfleis Is this fixed now?

@martinfleis
Copy link
Member Author

Don't know, we need to revert 3dd803b to check.

@jGaboardi
Copy link
Member

we should re-enable it once it gets fixed in geopandas 0.10.0.

Since geopandas==0.10.0 has been out for a while now, I will see how this behaves now.

@martinfleis
Copy link
Member Author

Still not working. RTD is not event trying.

@jGaboardi
Copy link
Member

The build is now failing, but at least it's running. Since the original problem was with the amount of numpy warning. I am 99% sure the current failure is due to the amount of pandas warnings for clip, .iloc, etc.

@martinfleis
Copy link
Member Author

Do we need a pdf at all?

@jGaboardi
Copy link
Member

That's a "Martin" decision in the end. I can see value in having it for those who would like access to rich docs in a secure data center or the like (as I have desperately desired in the past), but this is certainly an edge case. I will defer to your judgment on it. Maybe we even punt for now and try again once all the pandas warnings get worked out?

@martinfleis
Copy link
Member Author

Maybe we even punt for now and try again once all the pandas warnings get worked out?

+1

not really keen spending a ton of energy on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants