a question or a new idea about function:skip

[FrankWo18]

I wanna ask whether Pytest can achieve the following function. That is, dynamically modify whether to skip (the Mark object) before each test case is executed, and then make it take effect before the test case is executed. I've tried to use pytest_collection_modifyitems in conftest.py and modify the own_markers attribute of each item within it. However, this is fixed in the collection stage, and the new own_markers attribute won't be used again before the test case is executed.

Here's the code I try to make it happen:

[RonnyPfannschmidt]

At first glance the marker application looks correct

Please provide a minimal reproducer

Also, please consider using markers instead of magic lists in your declaration

[FrankWo18]

Convenience and easy maintenance are what I'm striving for

[graingert]

You can use a @contextlib.contextmanager, or a fixture to do the login instead

[FrankWo18]

This is Definitely a solution, but the interface 'login' isn't important here. I'm just using it as a demo. What are actually used are more specific business interfaces. Do we have to handle all those interfaces in this way?

[graingert]

with a context manager:

@contextlib.contextmanager
def _token():
    try:
        token = login()
    except LoginFailedError:
        token = None
    try:
        yield
    finally:
         if token is not None:
             logout(token)


def test_something():
    with _token() as token:
        ... # test here

with a fixture:

@pytest.fixture
def token():
    try:
        token = login()
    except LoginFailedError:
        token = None
    try:
        yield
    finally:
         # you don't technically need the try/finally in sync fixtures - but it is
         # needed in async fixtures so I use it everywhere
         if token is not None:
             logout(token)


def test_something(token):
        ... # test here

you can of course combine all of your setup and teardown steps into one big context manager or fixture

[graingert]

you should not be doing teardown with a separate test that you optionally skip

[FrankWo18]

I seem to have got some inspiration. I'll give it a try first. Thanks a lot!

[FrankWo18]

YES, it works using fixture!, just need more code lines, thanks!

[FrankWo18]