Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move Callable and other types that don't belong in collections.abc to another module #126470

Closed
DetachHead opened this issue Nov 6, 2024 · 8 comments
Labels
topic-typing type-feature A feature request or enhancement

Comments

@DetachHead
Copy link

DetachHead commented Nov 6, 2024

Feature or enhancement

Proposal:

types like Callable and Awaitable are completely unrelated to "collections", therefore collections.abc is clearly the wrong place for them, so the fact that typing.Callable and typing.Awaitable are deprecated in favor of these aliases is very confusing.

imo they should either be moved to a different module, or the versions in typing should be un-deprecated until a more suitable location for them is decided

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

@DetachHead DetachHead added the type-feature A feature request or enhancement label Nov 6, 2024
@KotlinIsland
Copy link
Contributor

KotlinIsland commented Nov 6, 2024

+ Hashable and Coroutine

@rruuaanng
Copy link
Contributor

+1

@Zheaoli
Copy link
Contributor

Zheaoli commented Nov 6, 2024

+1, would you like to submit a PR?

@Viicos
Copy link
Contributor

Viicos commented Nov 6, 2024

Duplicate: #69823

@DetachHead
Copy link
Author

+1, would you like to submit a PR?

sure. what module should i put them in? or should i just un-deprecate them for now so a decision can be made in the future regarding where they should go?

Duplicate: #69823

that issue is quite old and seems to have been closed without a proper solution, so if we close this issue as a duplicate i think that one should be re-opened

@ericvsmith
Copy link
Member

Moving them would break a ton of code. Please discuss this on discuss.python.org first.

@sobolevn
Copy link
Member

sobolevn commented Nov 6, 2024

I agree, this needs a discussion first. For now I will close the issue.
Please, feel free to reopen after the discussion is settled.

@sobolevn sobolevn closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-typing type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

8 participants