Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python implementation of pickle calls persistent_id() for a persistent id #126489

Closed
serhiy-storchaka opened this issue Nov 6, 2024 · 0 comments
Closed

Python implementation of pickle calls persistent_id() for a persistent id #126489

serhiy-storchaka opened this issue Nov 6, 2024 · 0 comments
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Nov 6, 2024 •
edited by bedevere-app bot
Loading

Bug report

Pickle allows to define the persistent_id() method in the Pickler class. If it is defined, it is called for every pickled object, and its result will be pickled instead if it is not None. In the Python implementation persistent_id() is also called for the result of persistent_id(), but the result of the second call is ignored. The C implementation only calls persistent_id() once. Calling it twice is just a waste of time in best case, and can have other negative impact (for example if reference for every object for which it was called is stored), so I consider it a bug.

It was found during work on #125752.

Linked PRs
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error 3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Nov 6, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 6, 2024
@serhiy-storchaka
pythongh-126489: Do not call persistent_id() for a persistent id in P…
e138301 
…ython pickle
@bedevere-app bedevere-app bot mentioned this issue Nov 6, 2024
Merged
serhiy-storchaka added a commit that referenced this issue Nov 6, 2024
@serhiy-storchaka
gh-126489: Do not call persistent_id() for a persistent id in Python …
8fa4dc4 
…pickle (GH-126490)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 6, 2024
@serhiy-storchaka @miss-islington
pythongh-126489: Do not call persistent_id() for a persistent id in P…
a8dd8e4 
…ython pickle (pythonGH-126490)

(cherry picked from commit 8fa4dc4)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Nov 6, 2024
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 6, 2024
@serhiy-storchaka
[3.12] pythongh-126489: Do not call persistent_id() for a persistent …
729c856 
…id in Python pickle (pythonGH-126490)

(cherry picked from commit 8fa4dc4)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Nov 6, 2024
Merged
serhiy-storchaka added a commit that referenced this issue Nov 6, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-126489: Do not call persistent_id() for a persistent id in …
9e115b1 
…Python pickle (GH-126490) (GH-126514)

(cherry picked from commit 8fa4dc4)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this issue Nov 6, 2024
@serhiy-storchaka
[3.12] gh-126489: Do not call persistent_id() for a persistent id in …
a19832b 
…Python pickle (GH-126490) (GH-126516)

(cherry picked from commit 8fa4dc4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes type-bug An unexpected behavior, bug, or error
Projects
Pickle and copy issues 🥒
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka