Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Check if generated files are up to date" job misses regen-unicodedata and regen-limited-abi #126524

Open
sobolevn opened this issue Nov 7, 2024 · 3 comments
Labels
build The build process and cross-build type-feature A feature request or enhancement

Comments

@sobolevn
Copy link
Member

sobolevn commented Nov 7, 2024

Feature or enhancement

Currently our regen-all is missing several regen- targets:

@echo "Note: make regen-stdlib-module-names, make regen-limited-abi, "
@echo "make regen-configure, make regen-sbom, and make regen-unicodedata should be run manually"

While our CI job to check regenerated files does not check them:

- name: Build CPython
run: |
make -j4 regen-all
make regen-stdlib-module-names regen-sbom
- name: Check for changes

This does not seem right, I think that we should add:

How long does it work? Testing locally first:

make regen-unicodedata  9.44s user 0.47s system 27% cpu 35.719 total
make regen-limited-abi  2.35s user 0.76s system 77% cpu 4.019 total (with pre-existing cache)

I propose adding these two make targets to the test to be extra safe.
What do others think? :)
If agreed, I will send a PR.

Linked PRs

@sobolevn sobolevn added type-feature A feature request or enhancement build The build process and cross-build labels Nov 7, 2024
@sobolevn
Copy link
Member Author

sobolevn commented Nov 7, 2024

I don't touch regen-configure here, because it will require a different solution, will create a new issue about it later.

@encukou
Copy link
Member

encukou commented Nov 11, 2024

There's no need to add regen-limited-abi, since the CI runs make check-limited-abi.
That checks that regen-limited-abi wouldn't make changes, and tries to generate a nicer message than you'd get just by comparing the resulting diff.

@sobolevn
Copy link
Member Author

When I add make regen-unicodedata here's how the CI speed changes:

Does not seem like it is slow now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants