Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emscripten: Get test suite passing #127146

Open
hoodmane opened this issue Nov 22, 2024 · 2 comments
Open

Emscripten: Get test suite passing #127146

hoodmane opened this issue Nov 22, 2024 · 2 comments
Labels
OS-emscripten tests Tests in the Lib/test dir

Comments

@hoodmane
Copy link
Contributor

hoodmane commented Nov 22, 2024 •
edited by bedevere-app bot
Loading

First I'd like to get the test suite to run all the way through, then to pass.

cc @freakboy3742

Update 2025/01/30

Emscripten 4.0.2 has fixes for all of the file system bugs I've looked into. There are still problems with nonblocking I/O which I haven't looked into.

Linked PRs

Emscripten PRs:
hoodmane added a commit to hoodmane/cpython that referenced this issue Nov 22, 2024
@hoodmane
pythongh-127146 Emscripten: Fix segfaults in test suite
040409a 
After this, Emscripten makes it all the way through the test suite when I run it
locally.
@bedevere-app bedevere-app bot mentioned this issue Nov 22, 2024
Merged
hoodmane added a commit to hoodmane/cpython that referenced this issue Nov 22, 2024
@hoodmane
pythongh-127146 Emscripten: Fix segfaults in test suite
a281d38 
After this, Emscripten makes it all the way through the test suite when I run it
locally.
hoodmane added a commit to hoodmane/cpython that referenced this issue Nov 22, 2024
@hoodmane
pythongh-127146 Emscripten: Fix segfaults in test suite
c11b73b 
After this, Emscripten makes it all the way through the test suite when I run it
locally.
hoodmane added a commit to hoodmane/cpython that referenced this issue Nov 23, 2024
@hoodmane
pythongh-127146 Emscripten: Skip segfaults in test suite
c6425ea 
After this, Emscripten makes it all the way through the test suite when I run it
locally.
@hoodmane
Copy link
Contributor Author

This upstream Emscripten PR fixes at least 13 test failures:
emscripten-core/emscripten#22998

@hoodmane
Copy link
Contributor Author

The tests involving readlink are fixed by this Emscripten PR: emscripten-core/emscripten#23000

@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
hoodmane added a commit to hoodmane/cpython that referenced this issue Dec 3, 2024
@hoodmane
pythongh-127146: Mark test_bz2 tests with requires_subprocess
cd1fe93
@bedevere-app bedevere-app bot mentioned this issue Dec 3, 2024
Closed
hoodmane added a commit to hoodmane/cpython that referenced this issue Dec 3, 2024
@hoodmane
pythongh-127146: Skip some minor problems in Emscripten tests
4bfeb60 
* Emscripten has_strftime_extensions
* fma doesn't handle negative zero correctly in Emscripten
* Emscripten has similar limited stack depth to wasi and apple in test_marshall
@bedevere-app bedevere-app bot mentioned this issue Dec 3, 2024
Merged
freakboy3742 pushed a commit that referenced this issue Dec 4, 2024
@hoodmane
gh-127146: Resolve some minor problems in Emscripten tests (#127565)
0f91078 
Adjusts some Emscripten test exclusions regarding strftime, fma, and stack depth.
freakboy3742 pushed a commit that referenced this issue Dec 5, 2024
@hoodmane
gh-127146: Emscripten: Skip segfaults in test suite (#127151)
43634fc 
Added skips for tests known to cause problems when running on Emscripten. 
These mostly relate to the limited stack depth on Emscripten.
@picnixz picnixz added the tests Tests in the Lib/test dir label Dec 5, 2024
hoodmane added a commit to hoodmane/cpython that referenced this issue Dec 11, 2024
@hoodmane
pythongh-127146: Emscripten some expected failures in time tests
262634c 
This xfails two tests in the test_time suite. It also adjusts test_os
to reflect the fact that in Emscripten file modification times in
nanoseconds since the linux epoch get round tripped through a 53 bit
integer so we only get 5 subsecond digits of precision.
@bedevere-app bedevere-app bot mentioned this issue Dec 11, 2024
Merged
freakboy3742 pushed a commit that referenced this issue Dec 12, 2024
@hoodmane
gh-127146: Some expected failures in Emscripten time tests (#127843)
41f29e5 
Disables two tests in the test_time suite, and adjusts test_os to reflect 
precision limits in Emscripten.
hoodmane added a commit to hoodmane/cpython that referenced this issue Dec 16, 2024
@hoodmane
pythongh-127146: Emscripten clean up test suite
4868732 
A lot of these skips are no longer necessary.
@bedevere-app bedevere-app bot mentioned this issue Dec 16, 2024
Merged
hoodmane added a commit to hoodmane/cpython that referenced this issue Dec 16, 2024
@hoodmane
pythongh-127146: Emscripten Include compiler version in _PYTHON_HOST_…
0c33f20 
…PLATFORM

`test_sysconfigdata_json` is failing. This doesn't entirely fix it but it moves
the failure later -- before it doesn't even find the sysconfigdata file because
of a descrepancy between what `uname()` returns and what `configure.ac` sets
`_PYTHON_HOST_PLATFORM` to. After, there are some small differences.
@bedevere-app bedevere-app bot mentioned this issue Dec 16, 2024
Merged
freakboy3742 pushed a commit that referenced this issue Dec 17, 2024
@hoodmane
gh-127146: Emscripten clean up test suite (#127984)
1183e4c 
Removed test skips that are no longer required as a result of Emscripten updates.
freakboy3742 pushed a commit that referenced this issue Dec 17, 2024
@hoodmane
gh-127146: Emscripten Include compiler version in _PYTHON_HOST_PLATFO…
b92f101 
…RM (#127992)

Modifies _PYTHON_HOST_PLATFORM to include the compiler version under
Emscripten. The Emscripten compiler version is the platform version
compatibility identifier.
hoodmane added a commit to hoodmane/cpython that referenced this issue Jan 6, 2025
@hoodmane
pythongh-127146: Fix test_sysconfidata_json in Emscripten
6e04c6d 
The prefix is different when we build from when we run the test.
hoodmane added a commit to hoodmane/cpython that referenced this issue Jan 6, 2025
@hoodmane
pythongh-127146: Fix test_sysconfidata_json in Emscripten
6d02cca 
The prefix is different when we build from when we run the test.
@bedevere-app bedevere-app bot mentioned this issue Jan 6, 2025
Closed
hoodmane added a commit to hoodmane/cpython that referenced this issue Jan 6, 2025
@hoodmane
pythongh-127146: skip some tests that are fixed on the main branch of…
7e77e68 
… Emscripten
@bedevere-app bedevere-app bot mentioned this issue Jan 6, 2025
Merged
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Resolve some minor problems in Emscripten tests (pyt…
4fe70db 
…hon#127565)

Adjusts some Emscripten test exclusions regarding strftime, fma, and stack depth.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Emscripten: Skip segfaults in test suite (python#127151
027ac70 
)

Added skips for tests known to cause problems when running on Emscripten. 
These mostly relate to the limited stack depth on Emscripten.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Some expected failures in Emscripten time tests (pyt…
c9158b1 
…hon#127843)

Disables two tests in the test_time suite, and adjusts test_os to reflect 
precision limits in Emscripten.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Emscripten clean up test suite (python#127984)
9d44349 
Removed test skips that are no longer required as a result of Emscripten updates.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Emscripten Include compiler version in _PYTHON_HOST_…
166fd0c 
…PLATFORM (python#127992)

Modifies _PYTHON_HOST_PLATFORM to include the compiler version under
Emscripten. The Emscripten compiler version is the platform version
compatibility identifier.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Fix test_sysconfigdata_json for Emscripten (python#1…
3124ddd 
…28556)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Skip Emscripten tests with pending fixes (python#128549
9c5b386 
)

Marks some additional tests as skipped on Emscripten. Many of these skips can be
reverted when the next Emscripten release is available.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Strip dash from Emscripten compiler version (python#…
6834b69 
…128557)

`emcc -dumpversion` will sometimes say e.g., `4.0.0-git` but in this case
uname does not include `-git` in the version string. Use cut to delete
everything after the dash.
@bedevere-app bedevere-app bot mentioned this issue Jan 27, 2025
Merged
hoodmane added a commit to hoodmane/cpython that referenced this issue Jan 27, 2025
@hoodmane
pythongh-127146: Update test skips for Emscripten 4.0.1
e2a80f3
freakboy3742 pushed a commit that referenced this issue Jan 28, 2025
@hoodmane
gh-127146: Update test skips for Emscripten 4.0.1 (#129375)
8e57877 
Updates the Emscripten test skips to reflect recent changes in Emscripten capabilities.
@bedevere-app bedevere-app bot mentioned this issue Jan 28, 2025
Merged
hoodmane added a commit to hoodmane/cpython that referenced this issue Jan 28, 2025
@hoodmane
pythongh-127146: Skip test_readinto_non_blocking on Emscripten
72c06e0 
non_blocking doesn't really work on Emscripten
hoodmane added a commit to hoodmane/cpython that referenced this issue Jan 28, 2025
@hoodmane
pythongh-127146: Don't compare userbase in test_sysconfig_json
7b424eb
hoodmane added a commit to hoodmane/cpython that referenced this issue Jan 28, 2025
@hoodmane
pythongh-127146: Don't compare userbase in test_sysconfig_json
145549f
@bedevere-app bedevere-app bot mentioned this issue Jan 28, 2025
Closed
freakboy3742 pushed a commit that referenced this issue Jan 28, 2025
@hoodmane
gh-127146: Skip test_readinto_non_blocking on Emscripten (#129421)
7893908 
Skips an additional test due to non_blocking not working reliably on Emscripten.
@hoodmane hoodmane reopened this Jan 29, 2025
hoodmane added a commit to hoodmane/cpython that referenced this issue Jan 30, 2025
@hoodmane
pythongh-127146: Update test skips for Emscripten 4.0.2
2ef8113
@bedevere-app bedevere-app bot mentioned this issue Jan 30, 2025
Merged
@hoodmane hoodmane mentioned this issue Feb 5, 2025
Merged
hoodmane added a commit to pyodide/pyodide that referenced this issue Feb 5, 2025
@hoodmane
Remove test skips no longer needed on Emscripten 3.1.74 (#5417)
6f27328 
Most but not all of the file system bug fixes tracked here made it into 3.1.74:
python/cpython#127146
freakboy3742 pushed a commit that referenced this issue Mar 16, 2025
@hoodmane
gh-127146: Update test skips for Emscripten 4.0.2 (#129474)
cf288e3 
Updates test skips to reflect capabilities of Emscripten 4.0.2.
plashchynski pushed a commit to plashchynski/cpython that referenced this issue Mar 17, 2025
@hoodmane @plashchynski
pythongh-127146: Update test skips for Emscripten 4.0.2 (python#129474)
03a9918 
Updates test skips to reflect capabilities of Emscripten 4.0.2.
hoodmane added a commit to hoodmane/cpython that referenced this issue Mar 24, 2025
@hoodmane
pythongh-127146: Fix Emscripten build with --pydebug
320e8da 
The deleted logic checks that the sysconfigdata is in a short list,
and the list does not allow the `d` ABI flag to be present. I removed
the check because I don't think it is helpful.
@bedevere-app bedevere-app bot mentioned this issue Mar 24, 2025
Merged
freakboy3742 pushed a commit that referenced this issue Mar 24, 2025
@hoodmane
gh-127146: Fix Emscripten build with --pydebug (#131672)
97ab8fc 
Removes an explicit check that sysconfigdata naming is correct, in favor of reporting at
runtime with the default mechanisms.
@hoodmane hoodmane mentioned this issue Mar 31, 2025
Closed
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 1, 2025
@hoodmane @diegorusso
pythongh-127146: Fix Emscripten build with --pydebug (python#131672)
e829a2c 
Removes an explicit check that sysconfigdata naming is correct, in favor of reporting at
runtime with the default mechanisms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-emscripten tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hoodmane @picnixz