Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 1: Diagram includes the non-existent "Replaced" state #1127

Closed
ncoghlan opened this issue Jul 21, 2019 · 14 comments · Fixed by #3725
Closed

PEP 1: Diagram includes the non-existent "Replaced" state #1127

ncoghlan opened this issue Jul 21, 2019 · 14 comments · Fixed by #3725
Assignees

Comments

@ncoghlan
Copy link
Contributor

I'm currently talking with a process management researcher, and asked them why their nominal process flow has a "Replaced" state in it.

Turns out they took it straight from the diagram in PEP 1: https://www.python.org/dev/peps/pep-0001/#pep-review-resolution

The "Superseded" box is labeled as "Replaced". That part of the diagram is weird anyway, as it's more likely to be Active PEPs that go to Superseded than Final ones.

@warsaw
Copy link
Member

warsaw commented Aug 5, 2019

The "Superseded" box is labeled as "Replaced". That part of the diagram is weird anyway, as it's more likely to be Active PEPs that go to Superseded than Final ones.

I'm not sure about that. IIRC, the original intent of this was something like the RFC 822 -> 2822 -> 5822 evolution. The idea being that further refinement of an already implemented (i.e. Final) PEP would include a Superseded link back to the original PEP.

Replaces is a little weird to me. I would change that to Supersedes.

@Jamim
Copy link
Contributor

Jamim commented Aug 6, 2019

Hello @ncoghlan and @warsaw,

I would change that to Supersedes.

Just in case, I'd like to point out that it looks like you are talking about different parts of the PEP-1.
So not only Replaces should be changed to Supersedes, but Replaced should be changed to Superseded as well.

@ncoghlan
Copy link
Contributor Author

Yeah, there are two inconsistencies. The "Replaced" state in the diagram is just outright wrong, as there's no such state (it's called "Superseded" in the PEP text).

The fact that the fields creating those doubly linked lists of PEPs are "Replaces" and "Superseded-By" is odd, but not wrong per se.

@pradyunsg
Copy link
Member

Are the sources for those files available in the repository?

@ncoghlan
Copy link
Contributor Author

The png is exported from the svg at https://github.com/python/peps/blob/master/pep-0001/process_flow.svg

We don't use the svg directly due to #701

@AA-Turner
Copy link
Member

Linking #2 here // PEP 676 re svg support

@AA-Turner
Copy link
Member

(turns out I can't link an issue in the UI, only PRs. Anyway the point stands!)
A

@CAM-Gerlach
Copy link
Member

(turns out I can't link an issue in the UI, only PRs. Anyway the point stands!)

In terms of the "linked issues"/"linked pull requests" feature, the purpose is to establish a more formal mechanism to allow merged PRs to close issues (though unfortunately, you can no longer have merged PRs close other PRs, which I believe used to work and is often useful).

@AA-Turner AA-Turner self-assigned this Jan 23, 2022
@AA-Turner
Copy link
Member

#2542 contains some recent discussion on updating this diagram.

A

@CAM-Gerlach
Copy link
Member

Ah, I thought there was an issue about that somewhere, but somehow managed to miss this one...

@mahamad1234

This comment was marked as spam.

@AlexWaygood

This comment was marked as resolved.

Jamim added a commit to Jamim/peps that referenced this issue Mar 16, 2024
The process flow diagram contained the non-existent Replaced PEP status.
The correct one is the Superseded.

Fixes python#1127
@Jamim
Copy link
Contributor

Jamim commented Mar 16, 2024

I believe it's about time to fix this 😅

@Jamim
Copy link
Contributor

Jamim commented Mar 23, 2024

Hello @AA-Turner,
Would you mind reviewing #3725 which fixes this issue?
Thanks in advance!

Jamim added a commit to Jamim/peps that referenced this issue Apr 3, 2024
The process flow diagram contained the non-existent Replaced PEP status.
The correct one is the Superseded.

Fixes python#1127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants