Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments for each parameter in config.yaml #293

Open
vfdev-5 opened this issue Aug 19, 2023 · 2 comments
Open

Add comments for each parameter in config.yaml #293

vfdev-5 opened this issue Aug 19, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@vfdev-5
Copy link
Member

vfdev-5 commented Aug 19, 2023

Right now we can see the following in the config.yaml:

seed: 777
data_path: ./
train_batch_size: 32
eval_batch_size: 32
num_workers: 4
max_epochs: 20
use_amp: false
debug: false
filename_prefix: training
n_saved: 2
save_every_iters: 1000
patience: 3
output_dir: ./logs
log_every_iters: 10
lr: 0.0001
model: resnet18

and it is unclear what each parameter is responsible for.

The idea is to add comments for each parameter like below

seed: 777  # random seed
data_path: ./  # input data path 
train_batch_size: 32
eval_batch_size: 32
num_workers: 4
max_epochs: 20
use_amp: false
debug: false
filename_prefix: training  # training checkpoint filename prefix
n_saved: 2  # number of saved checkpoints
save_every_iters: 1000  # training checkpoint frequency
patience: 3  # early stopping patience parameter
output_dir: ./logs  # output folder
log_every_iters: 10
lr: 0.0001
model: resnet18
@vfdev-5 vfdev-5 added enhancement New feature or request help wanted Extra attention is needed labels Aug 19, 2023
puhuk added a commit to puhuk/code-generator that referenced this issue Sep 13, 2023
vfdev-5 pushed a commit that referenced this issue Sep 18, 2023
* Update template-common/config.yaml

To resolve issue #293

* Update config.yaml

* Update config.yaml
puhuk added a commit to puhuk/code-generator that referenced this issue Sep 19, 2023
Update config for text-classification for issue pytorch-ignite#293
guptaaryan16 pushed a commit that referenced this issue Sep 19, 2023
* Update config for text-classification

Update config for text-classification for issue #293

* Update config.yaml

* Update config.yaml

* Update config.yaml
@puhuk
Copy link
Contributor

puhuk commented Sep 22, 2023

@vfdev-5 @guptaaryan16 Will that be necessary to add comments for other yaml files from ci-configs like this?

@guptaaryan16
Copy link
Contributor

No @puhuk ci-configs are for testing templates in the CI as you don't need to add them here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants