Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Refactoring Windows ARM64 - CPU Detection Logic #270

Closed
ozanMSFT opened this issue Dec 11, 2024 · 1 comment · Fixed by #283
Closed

Enhancement: Refactoring Windows ARM64 - CPU Detection Logic #270

ozanMSFT opened this issue Dec 11, 2024 · 1 comment · Fixed by #283

Comments

@ozanMSFT
Copy link
Contributor

ozanMSFT commented Dec 11, 2024 •
edited
Loading

Current source code supports some pre-defined chips by hardcoded definitions:

https://github.com/pytorch/cpuinfo/blob/main/src/arm/windows/init.c

Currently information is stored in:

woa_chip_info woa_chips[woa_chip_name_last]

It would be better to add capability to detect new chips without breaking existing implementation.

Otherwise, this will generate "Unknown CPU" warning/error message for the all undefined ARM64 chips.

Example error/warning messages:

Error in cpuinfo: Unknown chip model name 'Snapdragon(R) CPU'.
@tonybaloney
Copy link

The MIDR is stored in HKEY_LOCAL_MACHINE\HARDWARE\DESCRIPTION\System\CentralProcessor\0\CP 4000 where \0\ is the cpu ID.

Have suggested we use that instead

@ozanMSFT ozanMSFT mentioned this issue Mar 14, 2025
Merged
@ozanMSFT ozanMSFT mentioned this issue Mar 21, 2025
Closed
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this issue Mar 25, 2025
@ozanMSFT @pytorchmergebot
[Submodule] [cpuinfo] cpuinfo update (#149305)
ce54c43 
Updating `cpuinfo` module.

Relevant:
pytorch/cpuinfo#270
Pull Request resolved: #149305
Approved by: https://github.com/malfet
ozanMSFT added a commit to ozanMSFT/pytorch that referenced this issue Mar 27, 2025
@ozanMSFT
[Submodule] [cpuinfo] cpuinfo update (pytorch#149305)
9807aca 
Updating `cpuinfo` module.

Relevant:
pytorch/cpuinfo#270
Pull Request resolved: pytorch#149305
Approved by: https://github.com/malfet

(cherry picked from commit ce54c43)
ozanMSFT added a commit to ozanMSFT/pytorch that referenced this issue Mar 27, 2025
@ozanMSFT
[Submodule] [cpuinfo] cpuinfo update (pytorch#149305)
641c113 
Updating `cpuinfo` module.

Relevant:
pytorch/cpuinfo#270
Pull Request resolved: pytorch#149305
Approved by: https://github.com/malfet

(cherry picked from commit ce54c43)
@ozanMSFT ozanMSFT mentioned this issue Mar 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor windows arm64 for auto cpu detection ozanMSFT/cpuinfo
2 participants
@tonybaloney @ozanMSFT