Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HUD should differentiate between jobs that are in progress and jobs queueing/waiting for a runner #5822

Open
clee2000 opened this issue Oct 25, 2024 · 2 comments
Open

HUD should differentiate between jobs that are in progress and jobs queueing/waiting for a runner #5822

clee2000 opened this issue Oct 25, 2024 · 2 comments

Comments

@clee2000
Copy link
Contributor

clee2000 commented Oct 25, 2024 •
edited
Loading

Currently they both get the ?, making it difficult to tell if something is running or not

Maybe a • or something for one or just p or q or i depending on peoples preference
@huydhn huydhn self-assigned this Oct 25, 2024
@huydhn
Copy link
Contributor

huydhn commented Oct 25, 2024

Taking a screenshot to show what this issue is about given that we are having a long queue for MacOS runners atm

Screenshot 2024-10-25 at 11 19 40

@huydhn
Copy link
Contributor

huydhn commented Oct 25, 2024 •
edited
Loading

My notes for bootcamper:

  1. The code for HUD front page is at test-infra
  2. Here is the instruction on how to setup a local dev env for HUD (laptop is fine, no need for devgpu) https://github.com/pytorch/test-infra/tree/main/torchci
  3. The function to fetch the data from ClickHouse is at https://github.com/pytorch/test-infra/blob/main/torchci/lib/fetchHud.ts, we need to figure out a way to distinguish between pending jobs that are:
    1. Waiting for runner
    2. or already been assigned to a runner and running, but not yet finish

@huydhn huydhn removed their assignment Oct 25, 2024
@yangw-dev yangw-dev mentioned this issue Nov 4, 2024
Merged
yangw-dev added a commit that referenced this issue Nov 5, 2024
@yangw-dev
[HUD] Add job-status "QUEUED" (#5859)
37358dc 
# Overview
#5822
Add Queued status

# Details
- add `Queued` value in conclusion based on job.status
- add the UI changes in both the commit view, and the main trunk view.
- replace all string such as 'pending` to enum value JobStatus 

# Notice
there are other sqls are using 'pending' as default conclusion for empty
conclusion value , may create followup issues to address those.

# Next Steps
  replace the text to react-icons for rendering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
PyTorch OSS Dev Infra
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huydhn @clee2000