Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call get_world_size_and_rank ONCE #2316

Closed
joecummings opened this issue Jan 29, 2025 · 2 comments · Fixed by #2391
Closed

Call get_world_size_and_rank ONCE #2316

joecummings opened this issue Jan 29, 2025 · 2 comments · Fixed by #2391
Assignees
@krammnic

Comments

@joecummings
Copy link
Contributor

Not three times, cmon.
@krammnic
Copy link
Contributor

Extremely simple, let me open PR

@joecummings
Copy link
Contributor Author

Extremely simple, let me open PR

Just make sure it's after init_process_group

@krammnic krammnic mentioned this issue Feb 12, 2025
Merged
13 tasks
@joecummings joecummings linked a pull request Feb 13, 2025 that will close this issue
Reduce number of worlds #2391
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krammnic krammnic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce number of worlds krammnic/torchtune
2 participants
@joecummings @krammnic