Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume from checkpoint broken with distributed optimizer-in-backward #2360

Open
ebsmothers opened this issue Feb 7, 2025 · 0 comments
Open
Assignees

Comments

@ebsmothers
Copy link
Contributor

To repro: patch the changes in #2359 to enable optimizer-in-backward for two recipe tests that test resume from checkpoint functionality.

The single-device command succeeds:

pytest -m integration_test tests/recipes/test_full_finetune_single_device.py -k 'test_training_state_on_resume'

But the distributed one fails:

pytest -m integration_test tests/recipes/test_full_finetune_distributed.py -k 'test_training_state_on_resume[llama3/8B_full-llama3-tune-4-1-True]'

Full stack trace of the failure can be seen here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants