Make sure we never try to assign undefined to pointerEvents
#3392
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using a non-standard browser (https://coherent-labs.com/) for game UI. It handles unset `pointerEvents` unusually by returning `undefined` (where the spec would require an empty string). This fix makes this code resilient to such behavior. A bug was also submitted to their team, but I thought this is a nice harmless way to make sure `undefined` won't ever make its' way to `pointerEvents` (which would be a no-op)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm using a non-standard browser (https://coherent-labs.com/) for game UI. It handles unset
pointerEventsunusually by returningundefined(where the spec would require an empty string). This fix makes this code resilient to such behavior.A bug was also submitted to their team, but I thought this is a nice harmless way to make sure
undefinedwon't ever make its' way topointerEvents(which would be a no-op)