Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logging] Remove unnecessary context information #2514

Open
1 of 2 tasks
kevin85421 opened this issue Nov 7, 2024 · 1 comment · May be fixed by #2531
Open
1 of 2 tasks

[Logging] Remove unnecessary context information #2514

kevin85421 opened this issue Nov 7, 2024 · 1 comment · May be fixed by #2531
Assignees
@nadongjun
Labels
1.3.0 enhancement New feature or request good first issue Good for newcomers logging

Comments

@kevin85421
Copy link
Member

kevin85421 commented Nov 7, 2024 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

image

KubeRay log messages include context information, such as the RayCluster CR name and namespace as shown in the screenshot. However, some KubeRay logs redundantly print this same information. For example, the log message below also includes rayClusterName.

kuberay/ray-operator/controllers/ray/raycluster_controller.go

Line 259 in 4fc1799

"rayClusterName", instance.Name,

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added enhancement New feature or request triage logging 1.3.0 good first issue Good for newcomers and removed triage labels Nov 7, 2024
@kevin85421 kevin85421 mentioned this issue Nov 7, 2024
Open
2 tasks
@ray-project ray-project deleted a comment from EagleLo Nov 7, 2024
@nadongjun
Copy link

@kevin85421 Hi! I’d like to take this on—please assign it to me if possible. Thanks!

@nadongjun nadongjun linked a pull request Nov 11, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadongjun nadongjun

Labels
1.3.0 enhancement New feature or request good first issue Good for newcomers logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logging] Remove duplicate info in CR logs nadongjun/kuberay
2 participants
@kevin85421 @nadongjun