Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] S3 work_dir url with space causes task to hang in pending state #40546

Closed
larroy opened this issue Oct 21, 2023 · 7 comments
Closed

[Core] S3 work_dir url with space causes task to hang in pending state #40546

larroy opened this issue Oct 21, 2023 · 7 comments
Assignees
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core core-runtime-env Issues related to Ray environment dependencies good first issue Great starter issue for someone just starting to contribute to Ray P0.5 uueeehhh ray 2.10 size:small stability

Comments

@larroy
Copy link

larroy commented Oct 21, 2023

What happened + What you expected to happen

submitted a job with working-dir containing a s3 url with a space causes the task to hang in Pending state.

Versions / Dependencies

2.7.1

Reproduction script

ray job submit -v --working-dir "s3://bucket/key with space.zip" -- "ls -l"

Issue Severity

None

@larroy larroy added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Oct 21, 2023
@larroy larroy changed the title [Core] [Core] S3 work_dir url with space causes task to hang in pending state Oct 21, 2023
@larroy
Copy link
Author

larroy commented Oct 21, 2023

@anyscalesam
Copy link
Collaborator

@alexeykudinkin can you please triage this Ray Jobs issue?

@akshay-anyscale akshay-anyscale added core-runtime-env Issues related to Ray environment dependencies and removed job labels Oct 31, 2023
@akshay-anyscale
Copy link
Contributor

Reassigning to core team since it's a runtime env issue

@anyscalesam anyscalesam added the core Issues that should be addressed in Ray Core label Nov 1, 2023
@anyscalesam
Copy link
Collaborator

@larroy could you submit a PR with fix; should be straightforward and we can review.

@anyscalesam anyscalesam added the @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. label Nov 6, 2023
@anyscalesam anyscalesam added P2 Important issue, but not time-critical good first issue Great starter issue for someone just starting to contribute to Ray P1 Issue that should be fixed within a few weeks ray 2.9 Issues targeting Ray 2.9 release (~Q4 CY2023) and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) P2 Important issue, but not time-critical labels Nov 6, 2023
@rkooo567 rkooo567 added size:small ray 2.10 and removed ray 2.9 Issues targeting Ray 2.9 release (~Q4 CY2023) @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. labels Dec 8, 2023
@y-abe
Copy link
Contributor

y-abe commented Jan 9, 2024

I've identified a potential solution for the issue at hand. By adding a space to disallowed_chars, I was able to resolve the problem on my machine.

disallowed_chars = ["/", ":", "@", "+"]

If this aligns with your expectations, I'd be happy to make a pull request. Please let me know if this is acceptable to you.

@rkooo567
Copy link
Contributor

Maybe @jjyao already fixed the issue. He's going to verify it.

@anyscalesam anyscalesam self-assigned this Feb 9, 2024
@anyscalesam anyscalesam added P0.5 uueeehhh and removed P1 Issue that should be fixed within a few weeks labels May 10, 2024
@jjyao
Copy link
Collaborator

jjyao commented Sep 17, 2024

Fixed by #46767

@jjyao jjyao closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core core-runtime-env Issues related to Ray environment dependencies good first issue Great starter issue for someone just starting to contribute to Ray P0.5 uueeehhh ray 2.10 size:small stability
Projects
None yet
Development

No branches or pull requests

7 participants