Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aDAG][core] Multi arg DAG fails if it raises an exception. #47672

Closed
rkooo567 opened this issue Sep 16, 2024 · 2 comments
Closed

[aDAG][core] Multi arg DAG fails if it raises an exception. #47672

rkooo567 opened this issue Sep 16, 2024 · 2 comments
Labels
bug Something that is supposed to be working; but isn't compiled-graph core Issues that should be addressed in Ray Core triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@rkooo567
Copy link
Contributor

What happened + What you expected to happen

Right now, when you have multi arg task, and if it raises an exception, it couldn't handle the error. Ideally, all the downstream refs should raise an exception in this case.

class A:
    @ray.method(num_returns=2)
    def f(inp):
        raise Exception
        return 1, 2

with InputNode() as inp:
    x, y = a.f.bind(inp)
    dag = MultioutputNode([x, y])

Versions / Dependencies

master

Reproduction script

see above

Issue Severity

None

@rkooo567 rkooo567 added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) compiled-graph labels Sep 16, 2024
@anyscalesam anyscalesam added the core Issues that should be addressed in Ray Core label Sep 16, 2024
@stephanie-wang
Copy link
Contributor

@rkooo567 is this closed by #47704?

@rkooo567
Copy link
Contributor Author

Yes!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't compiled-graph core Issues that should be addressed in Ray Core triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

No branches or pull requests

3 participants