fix: re-enable skipped UI tests (#34)

Author: djelinek

settings.json

@@ -2,5 +2,7 @@
   "typescript.updateImportsOnFileMove.enabled": "always",
   "workbench.editor.enablePreview": true,
   "git.autoRepositoryDetection": false,
-  "terminal.integrated.sendKeybindingsToShell": true
+  "terminal.integrated.sendKeybindingsToShell": true,
+  "workbench.remoteIndicator.showExtensionRecommendations": false,
+  "extensions.ignoreRecommendations": true
 }

src/ui-test/bottomBar.test.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { BottomBarPanel, MarkerType, OutputView, ProblemsView, TerminalView, VSBrowser } from 'vscode-extension-tester';
+import { BottomBarPanel, EditorView, MarkerType, OutputView, ProblemsView, TerminalView, VSBrowser } from 'vscode-extension-tester';
 import * as path from 'path';
 import { expect } from 'chai';
 
@@ -65,6 +65,10 @@ describe('Bottom Bar Example Tests', function () {
 			}, 15000);
 		});
 
+		after(async function () {
+			await new EditorView().closeAllEditors();
+		});
+
 		// These tests use getAllVisibleMarkers() and are unreliable and should not be included.
 		//
 		// now we can look at the error markers
@@ -136,8 +140,7 @@ describe('Bottom Bar Example Tests', function () {
 	});
 
 	// lets test the output view now
-	// TODO: Fix
-	describe.skip('Output View', function () {
+	describe('Output View', function () {
 		let view: OutputView;
 
 		before(async function () {
@@ -156,28 +159,29 @@ describe('Bottom Bar Example Tests', function () {
 		});
 
 		it('Clear the output channel', async function () {
+			const delimiter = process.platform === 'win32' ? '\r\n' : '\n';
 			await view.clearText();
 			const text = await view.getText();
 
 			// now the log is technically empty, it just contains a newline character
-			expect(text).equals('\n');
+			expect(text).equals(delimiter);
 		});
 	});
 
-	// TODO: Fix
-	describe.skip('Terminal View', function () {
+	describe('Terminal View', function () {
 		let view: TerminalView;
 
 		before(async function () {
 			view = await bottomBar.openTerminalView();
 		});
 
-		it.skip('Execute a command', async function () {
-			await view.executeCommand('echo "hello world\\!"', 2000);
+		it('Execute a command', async function () {
+			const delimiter = process.platform === 'win32' ? '\r\n' : '\n';
+			await view.executeCommand('echo "hello world"', 2_000);
 
 			// now there should be a line saying 'hello world!' in the terminal
 			const text = await view.getText();
-			const textFound = text.split('\n').some((line) => line === 'hello world!');
+			const textFound = text.split(delimiter).some((line) => line === 'hello world');
 
 			expect(textFound).is.true;
 		});

src/ui-test/modalDialog.test.ts

@@ -16,17 +16,19 @@
  */
 
 import { expect } from 'chai';
-import { EditorView, ModalDialog, TextEditor, Workbench } from 'vscode-extension-tester';
+import { EditorView, InputBox, ModalDialog, TextEditor, Workbench } from 'vscode-extension-tester';
 
 // Example of handling a modal dialog
-// TODO: Fix
-describe.skip('Sample Modal Dialog Tests', () => {
+describe('Sample Modal Dialog Tests', () => {
 	let dialog: ModalDialog;
 
 	before(async () => {
 		// we need to open some modal dialog first, so lets try to close an unsaved file
 		// create a new file
 		await new Workbench().executeCommand('create new file');
+		const input = await InputBox.create();
+		await input.selectQuickPick('Text File');
+		await input.getDriver().sleep(500);
 		// make some changes
 		const editor = new TextEditor();
 		await editor.typeTextAt(1, 1, 'text');

src/ui-test/settingsEditor.test.ts

@@ -18,8 +18,7 @@
 import { expect } from 'chai';
 import { CheckboxSetting, SettingsEditor, Workbench } from 'vscode-extension-tester';
 
-// TODO: Fix
-describe.skip('Settings Editor sample tests', () => {
+describe('Settings Editor sample tests', () => {
 	let settings: SettingsEditor;
 
 	before(async () => {