Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes do not work within mermaid diagrams #1208

Closed
4 tasks done
lschierer opened this issue Aug 14, 2023 · 2 comments
Closed
4 tasks done

Footnotes do not work within mermaid diagrams #1208

lschierer opened this issue Aug 14, 2023 · 2 comments
Labels
🙋 no/question This does not need any changes 👎 phase/no Post cannot or will not be acted on

Comments

@lschierer
Copy link

Initial checklist

Affected packages and versions

"remark-rehype": "^10.0.0", "rehype-mermaidjs": "^1.0.1", "remark-gfm": "^3.0.1",

Link to runnable example

https://stackblitz.com/edit/github-3bxwan

Steps to reproduce

See the runnable example in stackblitz, however I initially hit this in a project using astro with tsc to build the typescript.

Expected behavior

the footnotes should work globally, because the gfm plugin should have processed first.

Actual behavior

the footnotes only work outside the mermaid diagram.

Runtime

Node v17, Node v16

Package manager

npm 8, pnpm

OS

macOS

Build and bundle tools

Vite, Other (please specify in steps to reproduce)

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 14, 2023
@ChristianMurphy
Copy link
Member

Welcome @lschierer! 👋
Codeblocks including mermaid do cannot have inner markdown.
Including references and footnotes.
This is by design, and how GFM works.

@ChristianMurphy ChristianMurphy closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2023
@ChristianMurphy ChristianMurphy added the 🙋 no/question This does not need any changes label Aug 14, 2023
@github-actions

This comment has been minimized.

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 no/question This does not need any changes 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

2 participants