Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doing history.go() does NOT trigger a blocker callback handler #933

Open
heath-freenome opened this issue Jan 25, 2022 · 1 comment
Open

Comments

@heath-freenome
Copy link

heath-freenome commented Jan 25, 2022

In order to properly implement the blocking capabilities in react-router 6 go needs to also do the same allowTx() processing as the other two actions. This is necessary because it may be important for an app to not to allow the browser navigation to move forward/backward based on some internal condition

It is also possible that the handlePop code isn't recognizing the registered blockers. Since doing navigate.go() using RR6 with with a custom blocker doesn't trigger the block handler... see this comment in RR6 issue for details. Or perhaps the go() code is not officially triggering the handlePop callback?

@heath-freenome heath-freenome changed the title go() does NOT support allowTx() doing history.go() does NOT trigger a blocker callback handler Jan 25, 2022
@chenzewang
Copy link

i got same question , likely: remix-run/react-router#5383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants