OS changed while updating a docker image #33166

sathieu · 2024-12-17T12:58:05Z

sathieu
Dec 17, 2024

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitLab ; Renovate 39.69.2

Please tell us more about your question or problem

When using an image with digest pointing to a specific architecture and os, renovate ensure the same architecture but can use another OS.

For example, this image:

registry.k8s.io/csi-vsphere/driver:v3.3.1@sha256:5ef2f153813565d41a41c0700d1917c077f30bbbe735fd3f9e9ba18956d65bed

which is os=linux architecture=amd64

Current behavior

Image is updated to:

registry.k8s.io/csi-vsphere/driver:v3.3.1@sha256:9245b0dbe11af8a90080e2d59a0e488bc6272b20d50eab3f643967c3d117a957

which is os=windows architecture=amd64

Expected behavior

Like for arcvhitecture, os should not be changed.

Logs (if relevant)

Logs

{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"No registry auth required for https://registry.k8s.io/v2/csi-vsphere/driver/tags/list?n=10000","time":"2024-12-16T16:05:52.623Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"getLabels(https://registry.k8s.io, csi-vsphere/driver, v3.3.1)","time":"2024-12-16T16:05:54.059Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"getManifestResponse(https://registry.k8s.io, csi-vsphere/driver, v3.3.1, get)","time":"2024-12-16T16:05:54.059Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"getManifestResponse(https://registry.k8s.io, csi-vsphere/driver, sha256:9245b0dbe11af8a90080e2d59a0e488bc6272b20d50eab3f643967c3d117a957, get)","time":"2024-12-16T16:05:54.350Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"getDigest(https://registry.k8s.io, csi-vsphere/driver, v3.3.1)","time":"2024-12-16T16:05:59.652Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"getManifestResponse(https://registry.k8s.io, csi-vsphere/driver, sha256:5ef2f153813565d41a41c0700d1917c077f30bbbe735fd3f9e9ba18956d65bed, head)","time":"2024-12-16T16:05:59.801Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"getManifestResponse(https://registry.k8s.io, csi-vsphere/driver, sha256:5ef2f153813565d41a41c0700d1917c077f30bbbe735fd3f9e9ba18956d65bed, get)","time":"2024-12-16T16:06:00.984Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","registryHost":"https://registry.k8s.io","dockerRepository":"csi-vsphere/driver","msg":"Architecture-specific digest or missing docker-content-digest header - pulling full manifest","time":"2024-12-16T16:06:05.445Z","v":0}
{"name":"renovate","hostname":"runner-j2nyww-s-project-27988771-concurrent-0","pid":17,"level":20,"logContext":"n3_5zRMcvzAkLFShThh2B","repository":"kubitus-project/kubitus-installer","msg":"getManifestResponse(https://registry.k8s.io, csi-vsphere/driver, v3.3.1, get)","time":"2024-12-16T16:06:05.445Z","v":0}

sathieu · 2024-12-17T13:01:24Z

sathieu
Dec 17, 2024
Author

Reproduction: https://github.com/sathieu/renovate-docker-os

And PR: https://github.com/sathieu/renovate-docker-os/pull/1/files

0 replies

rarkins · 2024-12-17T13:34:38Z

rarkins
Dec 17, 2024
Maintainer

What methods/commands are you using to determine os and architecture of those sha's?

4 replies

sathieu Dec 17, 2024
Author

@rarkins Currently the architecture is found in the manifest:

renovate/lib/modules/datasource/docker/index.ts

Line 418 in 3b9464c

const architecture = configResponse.body.architecture ?? null;

The os is at the exact same place.

sathieu Dec 17, 2024
Author

This is a required field. See https://github.com/opencontainers/image-spec/blob/5325ec48851022d6ded604199a3566254e72842a/config.md#properties

rarkins Dec 17, 2024
Maintainer

I'm asking how you took the SHAs above and converted them to os/architecture yourself (to confirm what you think is Renovate's bug). e.g. Did you manually run curl and inspect the manifest?

sathieu Dec 17, 2024
Author

crane config registry.k8s.io/csi-vsphere/driver:v3.3.1@sha256:5ef2f153813565d41a41c0700d1917c077f30bbbe735fd3f9e9ba18956d65bed

{
    "architecture": "amd64",
    "config": {
        "Env": [
            "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
        ],
        "Entrypoint": [
            "/bin/vsphere-csi"
        ],
        "WorkingDir": "/",
        "Labels": {
            "build-date": "20240707",
            "git_commit": "9008b4bf9c3e680bad5b8b1a6644733bbca14c84",
            "maintainers": "Divyen Patel \u003c[email protected]\u003e, Sandeep Pissay Srinivasa Rao \u003c[email protected]\u003e, Xing Yang \u003c[email protected]\u003e",
            "name": "Photon OS x86_64/4.0 Base Image",
            "vendor": "VMware"
        },
        "ArgsEscaped": true
    },
    "created": "2024-07-17T17:57:15Z",
    "history": [
        {
            "created": "2024-07-07T10:48:41Z",
            "created_by": "ADD photon-rootfs-4.0-56c8eb728.tar.gz / # buildkit",
            "comment": "buildkit.dockerfile.v0"
        },
        {
            "created": "2024-07-07T10:48:41Z",
            "created_by": "LABEL name=Photon OS x86_64/4.0 Base Image vendor=VMware build-date=20240707",
            "comment": "buildkit.dockerfile.v0",
            "empty_layer": true
        },
        {
            "created": "2024-07-07T10:48:41Z",
            "created_by": "CMD [\"/bin/bash\"]",
            "comment": "buildkit.dockerfile.v0",
            "empty_layer": true
        },
        {
            "created": "2024-07-11T04:11:47.784345625Z",
            "created_by": "ARG GIT_COMMIT",
            "comment": "buildkit.dockerfile.v0",
            "empty_layer": true
        },
        {
            "created": "2024-07-11T04:11:47.784345625Z",
            "created_by": "LABEL git_commit=9d3fa68e214252a3ce09b9a564bc97f53a346c7d",
            "comment": "buildkit.dockerfile.v0",
            "empty_layer": true
        },
        {
            "created": "2024-07-11T04:11:47.784345625Z",
            "created_by": "LABEL maintainers=Divyen Patel \u003c[email protected]\u003e, Sandeep Pissay Srinivasa Rao \u003c[email protected]\u003e, Xing Yang \u003c[email protected]\u003e",
            "comment": "buildkit.dockerfile.v0",
            "empty_layer": true
        },
        {
            "created": "2024-07-11T04:11:47.784345625Z",
            "created_by": "RUN |1 GIT_COMMIT=9d3fa68e214252a3ce09b9a564bc97f53a346c7d /bin/sh -c tdnf -y upgrade \u0026\u0026 tdnf clean all # buildkit",
            "comment": "buildkit.dockerfile.v0"
        },
        {
            "created": "2024-07-17T17:57:15Z",
            "created_by": "ARG GIT_COMMIT=9008b4bf9c3e680bad5b8b1a6644733bbca14c84",
            "comment": "buildkit.dockerfile.v0",
            "empty_layer": true
        },
        {
            "created": "2024-07-17T17:57:15Z",
            "created_by": "LABEL git_commit=9008b4bf9c3e680bad5b8b1a6644733bbca14c84",
            "comment": "buildkit.dockerfile.v0",
            "empty_layer": true
        },
        {
            "created": "2024-07-17T17:57:15Z",
            "created_by": "LABEL maintainers=Divyen Patel \u003c[email protected]\u003e, Sandeep Pissay Srinivasa Rao \u003c[email protected]\u003e, Xing Yang \u003c[email protected]\u003e",
            "comment": "buildkit.dockerfile.v0",
            "empty_layer": true
        },
        {
            "created": "2024-07-17T17:57:15Z",
            "created_by": "RUN |1 GIT_COMMIT=9008b4bf9c3e680bad5b8b1a6644733bbca14c84 /bin/sh -c tdnf -y install   nfs-utils   util-linux   e2fsprogs   xfsprogs # buildkit",
            "comment": "buildkit.dockerfile.v0"
        },
        {
            "created": "2024-07-17T17:57:15Z",
            "created_by": "RUN |1 GIT_COMMIT=9008b4bf9c3e680bad5b8b1a6644733bbca14c84 /bin/sh -c tdnf clean all # buildkit",
            "comment": "buildkit.dockerfile.v0"
        },
        {
            "created": "2024-07-17T17:57:15Z",
            "created_by": "COPY /build/vsphere-csi /bin/vsphere-csi # buildkit",
            "comment": "buildkit.dockerfile.v0"
        },
        {
            "created": "2024-07-17T17:57:15Z",
            "created_by": "ENTRYPOINT [\"/bin/vsphere-csi\"]",
            "comment": "buildkit.dockerfile.v0",
            "empty_layer": true
        }
    ],
    "os": "linux",
    "rootfs": {
        "type": "layers",
        "diff_ids": [
            "sha256:35922475c980c5ca339b1e47234e6b6170d0c4f32fcd16ba3e568a9c55e6722b",
            "sha256:ad7f8dec2b7d8be1c6616ef3c299af727d259f8cf31784777ca8460a0ef16a8b",
            "sha256:42119f81a03fcc64dbeb11b2f6249779750d0585516357d029aed6a9c81203d3",
            "sha256:e109b6b5522949e5c0cb90acbf0cc21baaba371c7dd2781793df5cd2c380cd28",
            "sha256:17d850e5c9f88e2c8c3172b9952f8693e383cddcb0a0334954aa14d1d45babc3"
        ]
    }
}

crane config registry.k8s.io/csi-vsphere/driver:v3.3.1@sha256:5ef2f153813565d41a41c0700d1917c077f30bbbe735fd3f9e9ba18956d65bed

{
    "architecture": "amd64",
    "config": {
        "User": "ContainerAdministrator",
        "Env": [
            "PATH=c:\\Windows\\System32;c:\\Windows"
        ],
        "Entrypoint": [
            "/csi.exe"
        ],
        "Labels": {
            "description": "vSphere CSI Driver Windows Plugin"
        },
        "OnBuild": null
    },
    "created": "2024-07-17T18:27:25.643532743Z",
    "history": [
        {
            "created": "2024-07-03T09:30:07.0748458Z",
            "created_by": "Apply image 10.0.20348.2582"
        },
        {
            "created": "2024-07-17T18:23:17.281410892Z",
            "created_by": "COPY /Windows/System32/netapi32.dll /Windows/System32/netapi32.dll # buildkit",
            "comment": "buildkit.dockerfile.v0"
        },
        {
            "created": "2024-07-17T18:27:25.643532743Z",
            "created_by": "USER ContainerAdministrator",
            "comment": "buildkit.dockerfile.v0",
            "empty_layer": true
        },
        {
            "created": "2024-07-17T18:27:25.643532743Z",
            "created_by": "LABEL description=vSphere CSI Driver Windows Plugin",
            "comment": "buildkit.dockerfile.v0",
            "empty_layer": true
        },
        {
            "created": "2024-07-17T18:27:25.643532743Z",
            "created_by": "COPY /build/bin/vsphere-csi.windows_amd64 ./csi.exe # buildkit",
            "comment": "buildkit.dockerfile.v0"
        },
        {
            "created": "2024-07-17T18:27:25.643532743Z",
            "created_by": "ENTRYPOINT [\"/csi.exe\"]",
            "comment": "buildkit.dockerfile.v0",
            "empty_layer": true
        }
    ],
    "moby.buildkit.buildinfo.v1": "eyJmcm9udGVuZCI6ImRvY2tlcmZpbGUudjAiLCJzb3VyY2VzIjpbeyJ0eXBlIjoiZG9ja2VyLWltYWdlIiwicmVmIjoiZG9ja2VyLmlvL2xpYnJhcnkvZ29sYW5nOjEuMjEiLCJwaW4iOiJzaGEyNTY6N2UwZTEzYWRkN2Y1N2EzZTAzMGVmNGM5MTgwODQzYWNlMmZmZjdjNzg4ZDU0YThiMTI5NDVkN2I1NzM5YTA1NSJ9LHsidHlwZSI6ImRvY2tlci1pbWFnZSIsInJlZiI6Imdjci5pby9rOHMtc3RhZ2luZy1lMmUtdGVzdC1pbWFnZXMvd2luZG93cy1zZXJ2ZXJjb3JlLWNhY2hlOjEuMC1saW51eC1hbWQ2NC1sdHNjMjAyMiIsInBpbiI6InNoYTI1NjplOWRlNWFjNDdhYWYyZjEyMzgyZGRkNzM2NjVlODdjNDIzMGFlYzliY2E1NzI2MjIzMjYyYzljMTk2YjBhYzcxIn0seyJ0eXBlIjoiZG9ja2VyLWltYWdlIiwicmVmIjoibWNyLm1pY3Jvc29mdC5jb20vd2luZG93cy9uYW5vc2VydmVyOmx0c2MyMDIyIiwicGluIjoic2hhMjU2OmNjOWY2YTEzMzQxOTBjMWYxOGE5MDVmNTZkMjg1MTMyZTU2MmE5YTFjZTE4ZmY5NDc2Y2ZhZjk1MTk0YWEwYjcifV19",
    "os": "windows",
    "os.version": "10.0.20348.2582",
    "rootfs": {
        "type": "layers",
        "diff_ids": [
            "sha256:f14357f03b64fd3d3b0b597822557ec58147476fcb8f444e9b1c95bb251b63a4",
            "sha256:7203dbc401b8a6eae1ab0bf503f69cd6ce8aee1d930c98227fc062374dff32ad",
            "sha256:a44bb15c440e33e41518271dcf4caf25ee935eca9200124289b03a448a0c6778"
        ]
    }
}

rarkins · 2024-12-17T16:41:28Z

rarkins
Dec 17, 2024
Maintainer

Converted to issue: #33173

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OS changed while updating a docker image #33166

{{title}}

Replies: 3 comments 4 replies

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

Select a reply

OS changed while updating a docker image #33166

sathieu Dec 17, 2024

How are you running Renovate?

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Please tell us more about your question or problem

Current behavior

Expected behavior

Logs (if relevant)

Replies: 3 comments · 4 replies

sathieu Dec 17, 2024 Author

rarkins Dec 17, 2024 Maintainer

sathieu Dec 17, 2024 Author

sathieu Dec 17, 2024 Author

rarkins Dec 17, 2024 Maintainer

sathieu Dec 17, 2024 Author

rarkins Dec 17, 2024 Maintainer

sathieu
Dec 17, 2024

Replies: 3 comments 4 replies

sathieu
Dec 17, 2024
Author

rarkins
Dec 17, 2024
Maintainer

sathieu Dec 17, 2024
Author

sathieu Dec 17, 2024
Author

rarkins Dec 17, 2024
Maintainer

sathieu Dec 17, 2024
Author

rarkins
Dec 17, 2024
Maintainer