Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renovate Bzlmod support requires version attribute even with git_override in place #33476

Open
rarkins opened this issue Jan 8, 2025 Discussed in #33421 · 1 comment
Open

Renovate Bzlmod support requires version attribute even with git_override in place #33476

rarkins opened this issue Jan 8, 2025 Discussed in #33421 · 1 comment
Labels
manager:bazel-module priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jan 8, 2025

Discussed in #33421

Originally posted by phst January 6, 2025

How are you running Renovate?

A Mend.io-hosted app

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

Repro (I hope the explanation there is sufficient): https://github.com/phst/renovate-bazel-dep

My uneducated guess would be that the version match in https://github.com/renovatebot/renovate/blob/39.91.0/lib/modules/manager/bazel-module/rules.ts#L72 should be made optional if a git_override is present.

Logs (if relevant)

See README of the repro repo
@rarkins rarkins added type:feature Feature (new functionality) priority-4-low Low priority, unlikely to be done unless it becomes important to more people manager:bazel-module labels Jan 8, 2025
@rarkins
Copy link
Collaborator Author

rarkins commented Jan 8, 2025

Reproduction forked to https://github.com/renovate-reproductions/33421

phst added a commit to phst/emacs that referenced this issue Jan 9, 2025
@phst
Reference new issue renovatebot/renovate#33476
70fafea
phst added a commit to phst/rules_elisp that referenced this issue Jan 9, 2025
@phst
Reference new issue renovatebot/renovate#33476
4dd8088
@rarkins rarkins added type:feature Feature (new functionality) and removed type:feature Feature (new functionality) labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
manager:bazel-module priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rarkins