Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad contrast on links in announcement bar for light mode #280

Open
HonkingGoose opened this issue Apr 3, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Apr 3, 2023

What browser are you using?

Firefox

Other browser name

No response

Describe the bug

The link text is unreadable in the "light mode"-variant of the announcement bar:

bad-contrast-links-in-announcement-bar

The links in the dark-mode variant of the announcement bar score AAA on the WCAG contrast checker in Firefox. So we only need to fix the light mode. 😄

Steps to reproduce

  1. Go to our public site: https://docs.renovatebot.com/
  2. Make sure you're viewing the light mode variant
  3. Open your browser's inspector tools for contrast and hover over the link text in the announcement bar, see WCAG contrast fail.

Additional context

Official docs about customizing the colors:

@HonkingGoose HonkingGoose added the bug Something isn't working label Apr 3, 2023
@HonkingGoose HonkingGoose changed the title Fix bad contrast on links in announcement bar Fix bad contrast on links in announcement bar for light mode Apr 3, 2023
@HonkingGoose
Copy link
Collaborator Author

HonkingGoose commented Apr 19, 2023

Maybe this PR has a clue on how we can fix our announcement bar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant