Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects : CSV export customised for HEPVS not working as expected #933

Open
mmo opened this issue Jun 28, 2023 · 1 comment
Open

Projects : CSV export customised for HEPVS not working as expected #933

mmo opened this issue Jun 28, 2023 · 1 comment
Assignees
Labels
bug Breaks something but is not blocking correction An implemented feature doesn't work as expected f: projects Related to projects

Comments

@mmo
Copy link
Collaborator

mmo commented Jun 28, 2023

Bug description:

Research projects have been customised for HEPVS, with the addition of several specific data fields that are not present in the standard version of research projects. When exporting HEPVS research projects to CSV ("Export as CSV" button), only standard fields are included in the CSV file.

This is a regression, as this feature was correctly implemented previously.

Expected behavior:

When exporting HEPVS research projects to CSV ("Export as CSV" button), all HEPVS custom data fields should be included in the CSV file.

Steps to Reproduce:

  1. Log in as admin for HEPVS
  2. Go to the "Research projects" page of the administration area
  3. Click on the "Export as CSV" button
  4. Open the downloaded CSV file, it should contain 30 data fields, but only 5 are present.
@mmo mmo added the bug Breaks something but is not blocking label Jun 28, 2023
@mmo mmo changed the title Custom CSV export : Projects : CSV export customised for HEPVS not working Jun 28, 2023
@mmo mmo changed the title Projects : CSV export customised for HEPVS not working Projects : CSV export customised for HEPVS not working as expected Jun 28, 2023
@mmo mmo assigned jma Jun 28, 2023
@mmo mmo added f: projects Related to projects correction An implemented feature doesn't work as expected labels Jun 28, 2023
@jma
Copy link
Contributor

jma commented Jun 28, 2023

The problem comes from some changes in flask-resources: https://github.com/inveniosoftware/flask-resources/blob/2f74ca86df50501742b949aa397ab6d4408224b3/flask_resources/content_negotiation.py#L97 the config is store in the context request at the application start. The solution can be to have only on config with a logic in the CSVSerializer depending on the current organisation. It can be usefull than this serializer can be usable also in a cli to export the projects in csv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking correction An implemented feature doesn't work as expected f: projects Related to projects
Projects
Status: Product Backlog
Development

No branches or pull requests

2 participants