You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
there is an issue because it adds a dependency on the core module.
Let's discuss how to plug such behavior.
As a side note it is linked with JMX capability which is nice
The text was updated successfully, but these errors were encountered:
add some setter for instance of those interfaces in the main class of core module such as org.restlet.Application
create new sub module with classes implement those interfaces and we add dependency to 3rd party library (such as dropwizard) to this sub module instead of core module
Just an idea. Sorry, I don't have lot of experience in design java application.
Using the application name to register the counter is probably not a good idea, since nothing prevents two applications from sharing a name.
Why not just offer this as a standalone class, possibly in an extension, with one public static method that application writers can use as follows:
public class MyApplication extends Application {
@Override public Restlet createInboundRoot() {
Router router = new Router(getContext());
... wire things up with router ...
return Metrics.withCounter(router, "my counter name");
}
I don't see a compelling need for deeper integration.
cf pull request: #1295 from @apirom9
there is an issue because it adds a dependency on the core module.
Let's discuss how to plug such behavior.
As a side note it is linked with JMX capability which is nice
The text was updated successfully, but these errors were encountered: