Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit ba646ff

Browse files
Markus ArmbrusterAnthony Liguori
Markus Armbruster
authored and
Anthony Liguori
committedJul 18, 2013
qtest: Don't reset on qtest chardev connect
libqtest's qtest_init() connecting to the qtest socket triggers reset. This was coded in the hope we could use the same QEMU process for multiple tests that way. Never used. Injects an extra reset even when it's not used, and that can mess up tests such as the one of -boot once I'm about to add. Drop it. Signed-off-by: Markus Armbruster <[email protected]> Message-id: [email protected] Signed-off-by: Anthony Liguori <[email protected]>
1 parent 1d9358e commit ba646ff

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed
 

‎qtest.c

+6-1
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,12 @@ static void qtest_event(void *opaque, int event)
472472

473473
switch (event) {
474474
case CHR_EVENT_OPENED:
475-
qemu_system_reset(false);
475+
/*
476+
* We used to call qemu_system_reset() here, hoping we could
477+
* use the same process for multiple tests that way. Never
478+
* used. Injects an extra reset even when it's not used, and
479+
* that can mess up tests, e.g. -boot once.
480+
*/
476481
for (i = 0; i < ARRAY_SIZE(irq_levels); i++) {
477482
irq_levels[i] = 0;
478483
}

0 commit comments

Comments
 (0)
Please sign in to comment.