Do custom sources/layers get downloaded in an offline map pack?

[kevinmanncito]

In our app we allow users to create an offline download of a map style. In our testing we thought that our sources/layers nested inside the map view were getting downloaded as part of the map pack but now we aren't so sure. It might have just been the cacheing that mapbox does that made us think the sources/layers were also being downloaded.

For example. Our mapview looks something like this -- using mapbox sdk v10:

<MapView styleUrl="mapbox://styles/mapbox/satellite-streets-v12">
  <VectorSource>
    <SymbolLayer />
  </VectorSource>

  <ShapeSource>
    <LineLayer />
  </ShapeSource>

  <RasterSource>
    <RasterLayer />
  </RasterSource>
</MapView>

And then to create the offline mapbox we are doing this:

offlineManager.createPack({
  name: // name,
  style: "mapbox://styles/mapbox/satellite-streets-v12",
  bounds: // bounds
})

Was our testing incorrect in thinking our sources/layers were being included in the mappack? Thanks!

[kevinmanncito]

I think I found the answer, tilesets don't appear to be included in an offline download if I'm understanding this correctly (at least for the ios sdk):

https://github.com/rnmapbox/maps/blob/main/ios/RNMBX/Offline/RNMBXOfflineModule.swift#L365

#if RNMBX_11
    let descriptorOptions = TilesetDescriptorOptions(
      styleURI: styleURI,
      zoomRange: zoomRange,
      tilesets: [], // RNMBX_11_TODO
      stylePackOptions: stylePackLoadOptions
    )
    #else
    let descriptorOptions = TilesetDescriptorOptions(
      styleURI: styleURI,
      zoomRange: zoomRange,
      stylePackOptions: stylePackLoadOptions
    )
#endif

[kevinmanncito]

@mfazekas made a PR that potentially addresses our issue: #3633

Its not 100% solid yet but would definitely appreciate your eyes on it. Thanks!