Build system updates (#94) #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavv
force-pushed
the
feature/doit
branch
5 times, most recently
from
ef435b9 to
17024c6
Compare
gavv
force-pushed
the
feature/doit
branch
2 times, most recently
from
501499e to
7cbf675
Compare
gavv
added
the
status: work in progress
gavv
force-pushed
the
feature/doit
branch
2 times, most recently
from
8ac22db to
8a481bc
Compare
gavv
added
status: ready for review
Izchomatik
reviewed
Feb 22, 2025
docs/development/automation.md
Outdated
|
|
||
| All commands are called from the root directory (using terminal). | ||
| - During development, you can run `doit check:android` or `doit test:android` frequently. These commands are fast and do the most basic checks. They don't do a full build and don't require a connected device. |
There was a problem hiding this comment.
Slight improvement (not critical) => "During development, you may frequently run doit check:android or doit test:android. These commands are quick and perform the most basic checks. They do not perform a full build and do not require a device to be connected."
docs/development/automation.md
Outdated
|
|
||
| ## Run linters | ||
| - From time to time, run `doit build:android` to do a full build, and `doit integration:android` to run integration tests on the connected device. These commands are heavy. |
There was a problem hiding this comment.
Slight improvement (not critical) => "Run doit build:android from time to time to perform a full build and doit integration:android to run integration tests on the connected device. These commands are heavy."
docs/development/automation.md
Outdated
| ``` | ||
|
|
||
| ## Generate code | ||
|
|
||
| Code generation is based on `build_runner` package. | ||
|
|
||
| Run all code generators: | ||
| Run all code generation (but not resource generation described in next section): |
There was a problem hiding this comment.
Slight improvement (not critical) => "Run all code generation (but not resource generation, described in the next section):"
Izchomatik
added
status: needs revision
gavv
force-pushed
the
feature/doit
branch
2 times, most recently
from
d6caddf to
07c4b54
Compare
gavv
added
status: ready for review
|
Thanks, applied! |
Fixes a warning described here: https://docs.flutter.dev/release/breaking-changes/flutter-generate-i10n-source
Current version produces AndroidManifest which triggers a warning. New version works fine.
New flutter sdk supports only kotlin >=1.8.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#94