Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main file for bower package #267

Open
cfwen opened this issue Sep 25, 2016 · 3 comments · Fixed by rastographics/jQuery-slimScroll#1 · May be fixed by #283
Open

main file for bower package #267

cfwen opened this issue Sep 25, 2016 · 3 comments · Fixed by rastographics/jQuery-slimScroll#1 · May be fixed by #283

Comments

@cfwen
Copy link

cfwen commented Sep 25, 2016

there are two main files in bower main entry:

"main": [
    "jquery.slimscroll.js",
    "jquery.slimscroll.min.js"
  ]

some auto build tools may include these two files automatically. use "jquery.slimscroll.min.js" is enough
@victor-lkmx
Copy link

victor-lkmx commented Sep 26, 2016 •
edited
Loading

Same here, I was about to create a similar ticket.

I would recommend to put the non-minified version since some people, for example myself, have a build script that take all the libraries and minify them when going to production.

@cfwen
Copy link
Author

cfwen commented Sep 26, 2016

yeah, I found my build tool will complaint for including .min.js file, so better to use "jquery.slimscroll.js"

@vip9
Copy link

vip9 commented Dec 9, 2016 •
edited
Loading

Still an issue with main-bower-files for gulp.
main should have got only "jquery.slimscroll.js"

rastographics pushed a commit to rastographics/jQuery-slimScroll that referenced this issue Mar 27, 2017
fix for bower
ef1d5c0 
fixes rochal#267
This was referenced Mar 27, 2017
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix for bower rastographics/jQuery-slimScroll
fix for bower rastographics/jQuery-slimScroll
3 participants
@vip9 @cfwen @victor-lkmx