Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Ronin::Support::Network::HTTP::CookieJar class #456

Open
postmodern opened this issue Sep 30, 2023 · 4 comments
Open

Add a Ronin::Support::Network::HTTP::CookieJar class #456

postmodern opened this issue Sep 30, 2023 · 4 comments
Labels
feature New Feature help-wanted Extra attention is needed http HTTP

Comments

@postmodern
Copy link
Member

Add a CookieJar class which can organize cookies, and query the cookies for a given URL, matching the URL's host and path to the cookie's Domain and Path constraints. This will allow us to add a cookie_jar: option to Ronin::Support::Network::HTTP#initialize and transparently track session cookies.

@postmodern postmodern added http HTTP feature New Feature help-wanted Extra attention is needed labels Sep 30, 2023
@Aniket-508
Copy link

I would like to work on this. Can you assign it to me? @postmodern

@postmodern
Copy link
Member Author

@Aniket-508 unfortunately, no. In the past whenever I assigned an issue to a new contributor they always disappeared and the issue never got completed.

@Aniket-508
Copy link

Hey, I promise it will be completed within max 3 days. I genuinely want to contribute.

@postmodern
Copy link
Member Author

@Aniket-508 feel free to start working on this issue, but be warned there are a lot of edge-cases with implementing a CookieJar claass, such as querying cookies by Domain (.example.com also matches sub-domains of example.com) and Path attributes. This code will need full YARD documentation and RSpec tests, which should test every edge-case of every public method. I'm not sure how much Ruby experience you have, but will probably take at least a week of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New Feature help-wanted Extra attention is needed http HTTP
Projects
None yet
Development

No branches or pull requests

2 participants