Skip to content

Commit 0ca285f

Browse files
committed
Include compiler in CI artifact names
Signed-off-by: Evan Flynn <[email protected]>
1 parent c68f69e commit 0ca285f

File tree

1 file changed

+17
-8
lines changed

1 file changed

+17
-8
lines changed

.github/workflows/build_test.yml

+17-8
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,15 @@ jobs:
118118
package-name: usb_cam
119119
target-ros2-distro: ${{ matrix.ros_distro }}
120120
vcs-repo-file-url: ""
121-
extra-cmake-args: -DCMAKE_C_COMPILER=${{ matrix.cc_compiler }} -DCMAKE_CXX_COMPILER=${{ matrix.cxx_compiler }}
121+
extra-cmake-args: -DCMAKE_C_COMPILER=${{ matrix.cc_compiler }} -DCMAKE_CXX_COMPILER=${{ matrix.cxx_compiler }} # -DLLVM_ENABLE_RUNTIMES=compiler-rt
122+
# TODO(flynneva): re-enable once code coverage works with differet compilers
123+
# colcon-defaults: |
124+
# {
125+
# "build": {
126+
# "mixin": ["coverage-gcc"]
127+
# }
128+
# }
129+
# colcon-mixin-repository: https://raw.githubusercontent.com/colcon/colcon-mixin-repository/b8436aa16c0bdbc01081b12caa253cbf16e0fb82/index.yaml
122130
# Compile again, this time enabling integration tests
123131
- name: Build integration tests
124132
shell: bash
@@ -132,13 +140,14 @@ jobs:
132140
renode_portable/renode --disable-gui --version
133141
- uses: actions/upload-artifact@v4
134142
with:
135-
name: colcon-logs-${{ matrix.ros_distro }}
143+
name: colcon-logs-${{ matrix.ros_distro }}-${{ matrix.cxx_compiler }}
136144
path: ${{ steps.build_and_test_step.outputs.ros-workspace-directory-name }}/log
137145
if: always()
138146
continue-on-error: true
139-
- uses: actions/upload-artifact@v4
140-
with:
141-
name: lcov-logs-${{ matrix.ros_distro }}
142-
path: ${{ steps.build_and_test_step.outputs.ros-workspace-directory-name }}/lcov
143-
if: always()
144-
continue-on-error: true
147+
# TODO(flynneva): re-enable once code coverage works with differet compilers
148+
# - uses: actions/upload-artifact@v4
149+
# with:
150+
# name: lcov-logs-${{ matrix.ros_distro }}-${{ matrix.cxx_compiler }}
151+
# path: ${{ steps.build_and_test_step.outputs.ros-workspace-directory-name }}/lcov
152+
# if: always()
153+
# continue-on-error: true

0 commit comments

Comments
 (0)