Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsumerThread terminates immediately #1052

Closed
Tacha-S opened this issue Nov 29, 2024 · 0 comments · Fixed by #1070
Closed

ConsumerThread terminates immediately #1052

Tacha-S opened this issue Nov 29, 2024 · 0 comments · Fixed by #1070

Comments

@Tacha-S
Copy link
Contributor

Tacha-S commented Nov 29, 2024

When running cameracheck from the camera_calibration package in ROS2 Jazzy, it subscribes to an image topic only once, performs the check, and then terminates. This behavior might be fine if the calibration board is always visible at the time of launch. However, it is quite inconvenient when the board needs to be moved into view after starting the node.

def run(self):
while rclpy.ok():
m = self.queue.get()
if self.queue.empty():
break
self.function(m)

Additionally, the results are output via print(), which may not be visible when launched through a launch file or similar methods. It would be better to use the ROS logger for consistent and accessible logging.

ahcorde pushed a commit that referenced this issue Feb 7, 2025
I made it so that it is checked multiple times instead of just once.

- fix #1052
mergify bot pushed a commit that referenced this issue Feb 7, 2025
I made it so that it is checked multiple times instead of just once.

- fix #1052

(cherry picked from commit 3e1a794)

# Conflicts:
#	camera_calibration/src/camera_calibration/camera_checker.py
@ahcorde ahcorde closed this as completed in 0908a96 Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant