You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
I've written two lexers which are quite company specific but I nevertheless would like them to be included into rouge because I use them for documentation with asciidoctor and rouge. Updating the gem folder of rouge with my changes is boring and error prone ;-)
I've als added some fixes for open issues which have not been handled so far.
My question is:
Is it better to issue a pull request for each issue and each lexer separately or is it sufficient to use one pull request for all of them?
Thanks in advance,
Ingo
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi,
I've written two lexers which are quite company specific but I nevertheless would like them to be included into rouge because I use them for documentation with asciidoctor and rouge. Updating the gem folder of rouge with my changes is boring and error prone ;-)
I've als added some fixes for open issues which have not been handled so far.
My question is:
Is it better to issue a pull request for each issue and each lexer separately or is it sufficient to use one pull request for all of them?
Thanks in advance,
Ingo
Beta Was this translation helpful? Give feedback.
All reactions