Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript private fields are being formatted as error #2022

Open
sphinxc0re opened this issue Jan 29, 2024 · 3 comments
Open

JavaScript private fields are being formatted as error #2022

sphinxc0re opened this issue Jan 29, 2024 · 3 comments
Labels
bugfix-request A request for a bugfix to be developed.

Comments

@sphinxc0re
Copy link

Name of the lexer
JavaScript

Code sample

export class DataPoint {
  #time = $.source($.proxy(new Date()));

  get time() {
    return $.get(this.#time);
  }
}

image

Those fields should ideally be part of the identifier

@sphinxc0re sphinxc0re added the bugfix-request A request for a bugfix to be developed. label Jan 29, 2024
@wedgebert
Copy link

Any word on this? We use rouge via GitLab and TypeScript files are a mess of random meaningless highlights that distract from the actual code diff

@tancnle
Copy link
Collaborator

tancnle commented Oct 17, 2024

@sphinxc0re @wedgebert I believe this #2076 will address the issue. I will have to push a new release.

@wedgebert
Copy link

That's awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix-request A request for a bugfix to be developed.
Projects
None yet
Development

No branches or pull requests

3 participants