Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depecrecation in session_set_save_handler() method with PHP 8.4 #9763

Open
2 tasks done
vmario89 opened this issue Feb 3, 2025 · 1 comment
Open
2 tasks done

Depecrecation in session_set_save_handler() method with PHP 8.4 #9763

vmario89 opened this issue Feb 3, 2025 · 1 comment

Comments

@vmario89
Copy link

vmario89 commented Feb 3, 2025

Prerequisites

  • I have searched for duplicate or closed issues
  • I can recreate the issue with all plugins disabled

Describe the issue

Hi,
since updating Roundcube 1.6.9 to use PHP8.4 i get a spam flood of deprecations in the session handler. The issue persists, even when i disable all plugins.

In the install notes it's recommended to have PHP greater 7.3 - i did not read anything about upper limit of the version. https://github.com/roundcube/roundcubemail/blob/release-1.6/INSTALL

this comes from nginx error log file:

2025/02/03 10:38:24 [error] 3918174#3918174: *236159 FastCGI sent in stderr: "PHP message: PHP Deprecated:  session_set_save_handler(): Providing individual callbacks instead of an object implementing SessionHandlerInterface is deprecated in /var/www/roundcube/program/lib/Roundcube/rcube_session.php on line 119" while reading response header from upstream, client: REDACTED, server: REDACTED.REDACTED.REDACTED, request: "GET /robots.txt HTTP/1.1", upstream: "fastcgi://unix:/var/run/php-fpm/php84.sock:", host: REDACTED

thank you!

What browser(s) are you seeing the problem on?

Other

What version of PHP are you using?

8.4

What version of Roundcube are you using?

1.6.9

JavaScript errors

No response

PHP errors

No response

@vmario89 vmario89 changed the title Depecrecation in session_set_save_handler() method Depecrecation in session_set_save_handler() method with PHP 8.4 Feb 3, 2025
@alecpl
Copy link
Member

alecpl commented Feb 3, 2025

This has been solved in master, but the change is quite big, so I don't plan a backport. You should be able to configure PHP to do not log such errors.

Some other deprecation warnings are also expected in 1.6 under PHP >= 8.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants