Skip to content

Commit 12e0d02

Browse files
koickoic
committed
Import Rails cops from RuboCop Core
These are committing parts that were not picked up by `git cherry-pick` from RuboCop Core.
1 parent 1a47ba4 commit 12e0d02

10 files changed

+754
-0
lines changed

‎.rspec

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
--color
2+
--require spec_helper

‎.rubocop.yml

+93
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,93 @@
1+
# This is the configuration used to check the rubocop source code.
2+
3+
inherit_from: .rubocop_todo.yml
4+
require:
5+
- rubocop/cop/internal_affairs
6+
- rubocop-rspec
7+
8+
AllCops:
9+
Exclude:
10+
- 'vendor/**/*'
11+
- 'spec/fixtures/**/*'
12+
- 'tmp/**/*'
13+
TargetRubyVersion: 2.2
14+
15+
Naming/PredicateName:
16+
# Method define macros for dynamically generated method.
17+
MethodDefinitionMacros:
18+
- define_method
19+
- define_singleton_method
20+
- def_node_matcher
21+
- def_node_search
22+
23+
Style/FrozenStringLiteralComment:
24+
EnforcedStyle: always
25+
26+
Style/FormatStringToken:
27+
# Because we parse a lot of source codes from strings. Percent arrays
28+
# look like unannotated format string tokens to this cop.
29+
Exclude:
30+
- spec/**/*
31+
32+
Style/IpAddresses:
33+
# The test for this cop includes strings that would cause offenses
34+
Exclude:
35+
- spec/rubocop/cop/style/ip_addresses_spec.rb
36+
37+
Layout/EndOfLine:
38+
EnforcedStyle: lf
39+
40+
Layout/ClassStructure:
41+
Enabled: true
42+
Categories:
43+
module_inclusion:
44+
- include
45+
- prepend
46+
- extend
47+
ExpectedOrder:
48+
- module_inclusion
49+
- constants
50+
- public_class_methods
51+
- initializer
52+
- instance_methods
53+
- protected_methods
54+
- private_methods
55+
56+
Layout/IndentHeredoc:
57+
EnforcedStyle: powerpack
58+
59+
# Trailing white space is meaningful in code examples
60+
Layout/TrailingWhitespace:
61+
AllowInHeredoc: true
62+
63+
Lint/AmbiguousBlockAssociation:
64+
Exclude:
65+
- 'spec/**/*.rb'
66+
67+
Lint/InterpolationCheck:
68+
Exclude:
69+
- 'spec/**/*.rb'
70+
71+
Lint/UselessAccessModifier:
72+
MethodCreatingMethods:
73+
- 'def_matcher'
74+
- 'def_node_matcher'
75+
76+
Lint/BooleanSymbol:
77+
Enabled: false
78+
79+
Metrics/BlockLength:
80+
Exclude:
81+
- 'Rakefile'
82+
- '**/*.rake'
83+
- 'spec/**/*.rb'
84+
85+
Metrics/ModuleLength:
86+
Exclude:
87+
- 'spec/**/*.rb'
88+
89+
RSpec/PredicateMatcher:
90+
EnforcedStyle: explicit
91+
92+
RSpec/NestedGroups:
93+
Max: 7

‎.rubocop_todo.yml

+69
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,69 @@
1+
# This configuration was generated by
2+
# `rubocop --auto-gen-config`
3+
# on 2018-07-14 05:02:14 +0900 using RuboCop version 0.58.1.
4+
# The point is for the user to remove these configuration records
5+
# one by one as the offenses are removed from the code base.
6+
# Note that changes in the inspected code, or installation of new
7+
# versions of RuboCop, may require this file to be generated again.
8+
9+
# Offense count: 1
10+
# Cop supports --auto-correct.
11+
Lint/UnneededCopDisableDirective:
12+
Exclude:
13+
- 'rubocop-rails.gemspec'
14+
15+
# Offense count: 7
16+
Metrics/AbcSize:
17+
Max: 18
18+
19+
# Offense count: 3
20+
# Configuration parameters: CountComments.
21+
Metrics/ClassLength:
22+
Max: 146
23+
24+
# Offense count: 7
25+
# Configuration parameters: CountComments.
26+
Metrics/MethodLength:
27+
Max: 14
28+
29+
# Offense count: 61
30+
# Configuration parameters: Prefixes.
31+
# Prefixes: when, with, without
32+
RSpec/ContextWording:
33+
Exclude:
34+
- 'spec/rubocop/cop/rails/blank_spec.rb'
35+
- 'spec/rubocop/cop/rails/bulk_change_table_spec.rb'
36+
- 'spec/rubocop/cop/rails/delegate_spec.rb'
37+
- 'spec/rubocop/cop/rails/exit_spec.rb'
38+
- 'spec/rubocop/cop/rails/file_path_spec.rb'
39+
- 'spec/rubocop/cop/rails/has_many_or_has_one_dependent_spec.rb'
40+
- 'spec/rubocop/cop/rails/inverse_of_spec.rb'
41+
- 'spec/rubocop/cop/rails/present_spec.rb'
42+
- 'spec/rubocop/cop/rails/read_write_attribute_spec.rb'
43+
- 'spec/rubocop/cop/rails/redundant_receiver_in_with_options_spec.rb'
44+
- 'spec/rubocop/cop/rails/reversible_migration_spec.rb'
45+
- 'spec/rubocop/cop/rails/safe_navigation_spec.rb'
46+
47+
# Offense count: 174
48+
# Configuration parameters: Max.
49+
RSpec/ExampleLength:
50+
Enabled: false
51+
52+
# Offense count: 38
53+
# Configuration parameters: AggregateFailuresByDefault.
54+
RSpec/MultipleExpectations:
55+
Max: 5
56+
57+
# Offense count: 1
58+
# Cop supports --auto-correct.
59+
# Configuration parameters: EnforcedStyle.
60+
# SupportedStyles: when_needed, always, never
61+
Style/FrozenStringLiteralComment:
62+
Exclude:
63+
- 'spec/spec_helper.rb'
64+
65+
# Offense count: 1
66+
# Cop supports --auto-correct.
67+
Style/IfUnlessModifier:
68+
Exclude:
69+
- 'spec/spec_helper.rb'

‎config/default.yml

+205
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,205 @@
1+
# This is the default configuration file. Enabling and disabling is configured
2+
# in separate files. This file adds all other parameters apart from Enabled.
3+
4+
inherit_from:
5+
- enabled.yml
6+
- disabled.yml
7+
8+
# Common configuration.
9+
AllCops:
10+
# What version of Rails is the inspected code using? If a value is specified
11+
# for TargetRailsVersion then it is used. Acceptable values are specificed
12+
# as a float (i.e. 5.1); the patch version of Rails should not be included.
13+
# If TargetRailsVersion is not set, RuboCop will parse the Gemfile.lock or
14+
# gems.locked file to find the version of Rails that has been bound to the
15+
# application. If neither of those files exist, RuboCop will use Rails 5.0
16+
# as the default.
17+
TargetRailsVersion: ~
18+
19+
Rails/ActionFilter:
20+
EnforcedStyle: action
21+
SupportedStyles:
22+
- action
23+
- filter
24+
Include:
25+
- app/controllers/**/*.rb
26+
27+
Rails/AssertNot:
28+
Include:
29+
- '**/test/**/*'
30+
31+
Rails/Blank:
32+
# Convert usages of `nil? || empty?` to `blank?`
33+
NilOrEmpty: true
34+
# Convert usages of `!present?` to `blank?`
35+
NotPresent: true
36+
# Convert usages of `unless present?` to `if blank?`
37+
UnlessPresent: true
38+
39+
Rails/BulkChangeTable:
40+
Database: null
41+
SupportedDatabases:
42+
- mysql
43+
- postgresql
44+
Include:
45+
- db/migrate/*.rb
46+
47+
Rails/CreateTableWithTimestamps:
48+
Include:
49+
- db/migrate/*.rb
50+
51+
Rails/Date:
52+
# The value `strict` disallows usage of `Date.today`, `Date.current`,
53+
# `Date#to_time` etc.
54+
# The value `flexible` allows usage of `Date.current`, `Date.yesterday`, etc
55+
# (but not `Date.today`) which are overridden by ActiveSupport to handle current
56+
# time zone.
57+
EnforcedStyle: flexible
58+
SupportedStyles:
59+
- strict
60+
- flexible
61+
62+
Rails/Delegate:
63+
# When set to true, using the target object as a prefix of the
64+
# method name without using the `delegate` method will be a
65+
# violation. When set to false, this case is legal.
66+
EnforceForPrefixed: true
67+
68+
Rails/DynamicFindBy:
69+
Whitelist:
70+
- find_by_sql
71+
72+
Rails/EnumUniqueness:
73+
Include:
74+
- app/models/**/*.rb
75+
76+
Rails/Exit:
77+
Include:
78+
- app/**/*.rb
79+
- config/**/*.rb
80+
- lib/**/*.rb
81+
Exclude:
82+
- lib/**/*.rake
83+
84+
Rails/FilePath:
85+
EnforcedStyle: arguments
86+
SupportedStyles:
87+
- slashes
88+
- arguments
89+
90+
Rails/FindBy:
91+
Include:
92+
- app/models/**/*.rb
93+
94+
Rails/FindEach:
95+
Include:
96+
- app/models/**/*.rb
97+
98+
Rails/HasAndBelongsToMany:
99+
Include:
100+
- app/models/**/*.rb
101+
102+
Rails/HasManyOrHasOneDependent:
103+
Include:
104+
- app/models/**/*.rb
105+
106+
Rails/HttpStatus:
107+
EnforcedStyle: symbolic
108+
SupportedStyles:
109+
- numeric
110+
- symbolic
111+
112+
Rails/InverseOf:
113+
Include:
114+
- app/models/**/*.rb
115+
116+
Rails/LexicallyScopedActionFilter:
117+
Include:
118+
- app/controllers/**/*.rb
119+
120+
Rails/NotNullColumn:
121+
Include:
122+
- db/migrate/*.rb
123+
124+
Rails/Output:
125+
Include:
126+
- app/**/*.rb
127+
- config/**/*.rb
128+
- db/**/*.rb
129+
- lib/**/*.rb
130+
131+
Rails/Present:
132+
# Convert usages of `!nil? && !empty?` to `present?`
133+
NotNilAndNotEmpty: true
134+
# Convert usages of `!blank?` to `present?`
135+
NotBlank: true
136+
# Convert usages of `unless blank?` to `if present?`
137+
UnlessBlank: true
138+
139+
Rails/ReadWriteAttribute:
140+
Include:
141+
- app/models/**/*.rb
142+
143+
Rails/RefuteMethods:
144+
Include:
145+
- '**/test/**/*'
146+
147+
Rails/RequestReferer:
148+
EnforcedStyle: referer
149+
SupportedStyles:
150+
- referer
151+
- referrer
152+
153+
Rails/ReversibleMigration:
154+
Include:
155+
- db/migrate/*.rb
156+
157+
Rails/SafeNavigation:
158+
# This will convert usages of `try` to use safe navigation as well as `try!`.
159+
# `try` and `try!` work slightly differently. `try!` and safe navigation will
160+
# both raise a `NoMethodError` if the receiver of the method call does not
161+
# implement the intended method. `try` will not raise an exception for this.
162+
ConvertTry: false
163+
164+
Rails/ScopeArgs:
165+
Include:
166+
- app/models/**/*.rb
167+
168+
Rails/TimeZone:
169+
# The value `strict` means that `Time` should be used with `zone`.
170+
# The value `flexible` allows usage of `in_time_zone` instead of `zone`.
171+
EnforcedStyle: flexible
172+
SupportedStyles:
173+
- strict
174+
- flexible
175+
176+
Rails/UniqBeforePluck:
177+
EnforcedStyle: conservative
178+
SupportedStyles:
179+
- conservative
180+
- aggressive
181+
AutoCorrect: false
182+
183+
Rails/UnknownEnv:
184+
Environments:
185+
- development
186+
- test
187+
- production
188+
189+
Rails/SkipsModelValidations:
190+
Blacklist:
191+
- decrement!
192+
- decrement_counter
193+
- increment!
194+
- increment_counter
195+
- toggle!
196+
- touch
197+
- update_all
198+
- update_attribute
199+
- update_column
200+
- update_columns
201+
- update_counters
202+
203+
Rails/Validation:
204+
Include:
205+
- app/models/**/*.rb

0 commit comments

Comments
 (0)